Handle a field named "result", "other", or "o" #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1463,6 +1463,9 @@ private void emitMessageHashCode(MessageType messageType) throws IOException { | |||
| } else if (hasOnlyOneField(messageType)) { | |||
| Field field = messageType.getFields().get(0); | |||
| String name = sanitize(field.getName()); | |||
| if ("result".equals(name)) { | |||
There was a problem hiding this comment.
One liners are for return statements only (and even then I hate them)
There was a problem hiding this comment.
Needs a comment explaining why qualification is needed.
|
LGTM. |
|
I'll add a comment and also fix the issue with equals() before merging. |
danrice67
pushed a commit
that referenced
this pull request
Oct 1, 2013
Handle a field named "result", "other", or "o"
|
👍 |
mattprecious
pushed a commit
that referenced
this pull request
Apr 15, 2014
Fix IllegalStateException when trying to add a header or footer to the CalendarPickerView on Samsung Galaxy Nexus running Android 4.2.2
swankjesse
added a commit
that referenced
this pull request
Jul 13, 2015
Properly handle nested types when converting to map.
JakeWharton
pushed a commit
that referenced
this pull request
Jun 23, 2020
* commit '860c3a191d9cf30b907ceb02d4f4bb5364348ed7': Add support for encoding Int to Int maps Reorganize methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.