Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin: Annotate workflow-ui-* as experimental #55

Closed
rjrjr opened this issue Mar 26, 2020 · 0 comments · Fixed by #91
Closed

Kotlin: Annotate workflow-ui-* as experimental #55

rjrjr opened this issue Mar 26, 2020 · 0 comments · Fixed by #91
Assignees
@rjrjr
Labels
ui Related to UI integration
Projects
Workflow Kotlin
Milestone
v1.0.0-beta.1

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Mar 26, 2020

The UI classes are robust, but we're still messing with the API a bit and ramping up their production use. Meanwhile, core is basically done. Let's decouple their releases.
@rjrjr rjrjr changed the title Kotlin: Any view code not used in production should be demoted to sample Kotlin: Annotate workflow-ui-* as experimental Jun 27, 2020
@zach-klippenstein zach-klippenstein transferred this issue from square/workflow Jun 27, 2020
@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jun 27, 2020
zach-klippenstein added a commit that referenced this issue Jun 28, 2020
@zach-klippenstein
Remove unnecessary data classes from public, non-experimental APIs.
749f01b 
The only such data classes were `WorkflowTestParams` and `RenderingAndSnapshot`.
The former has no need to be a data class, as it's just passed as configuration
to the test function, and the latter is effectively just an alias for `Pair` and
the shape is fundamental to the workflow runtime design so it won't change.

There are still some data classes in the UI modules, but #55 will mark all those
as `ExperimentalWorkflowApi` before releasing 1.0.0.

Fixes #57.
@zach-klippenstein zach-klippenstein mentioned this issue Jun 28, 2020
Merged
@zach-klippenstein zach-klippenstein added the ui Related to UI integration label Jun 29, 2020
This was referenced Jun 29, 2020
Closed
Closed
Closed
Closed
@rjrjr rjrjr added this to In progress in Workflow Kotlin Jun 30, 2020
@rjrjr rjrjr self-assigned this Jun 30, 2020
rjrjr added a commit that referenced this issue Jun 30, 2020
@rjrjr
Introduces WorkflowUiExperimentalApi opt-in annotation.
878566b 
Closes #55
@rjrjr rjrjr mentioned this issue Jun 30, 2020
Merged
@rjrjr rjrjr moved this from In progress to Review in progress in Workflow Kotlin Jun 30, 2020
rjrjr added a commit that referenced this issue Jul 1, 2020
@rjrjr
Introduces WorkflowUiExperimentalApi opt-in annotation.
c36e28c 
Closes #55
@rjrjr rjrjr closed this as completed in #91 Jul 1, 2020
Workflow Kotlin automation moved this from Review in progress to Done Jul 1, 2020
zach-klippenstein pushed a commit that referenced this issue Feb 4, 2021
@rjrjr
Merge pull request #55 from square/zachklipp/rename-trunk-to-main
a4636fc 
Rename references to trunk to main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjrjr rjrjr

Labels
ui Related to UI integration
Projects
Workflow Kotlin
  
Done
Milestone
v1.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Introduces WorkflowUiExperimentalApi opt-in annotation. square/workflow-kotlin
2 participants
@zach-klippenstein @rjrjr