Remove unnecessary data classes from public, non-experimental APIs. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only such data classes were `WorkflowTestParams` and `RenderingAndSnapshot`. The former has no need to be a data class, as it's just passed as configuration to the test function, and the latter is effectively just an alias for `Pair` and the shape is fundamental to the workflow runtime design so it won't change. There are still some data classes in the UI modules, but #55 will mark all those as `ExperimentalWorkflowApi` before releasing 1.0.0. Fixes #57.
rjrjr
approved these changes
Jun 28, 2020
|
I've been carefully to avoid introducing new ones, and most of our public APIs are just interfaces anyway. |
zach-klippenstein
added a commit
that referenced
this pull request
Feb 4, 2021
Upgrade AGP, Gradle, Compose, and Kotlin versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only such data classes were
WorkflowTestParamsandRenderingAndSnapshot.The former has no need to be a data class, as it's just passed as configuration
to the test function, and the latter is effectively just an alias for
Pairandthe shape is fundamental to the workflow runtime design so it won't change.
There are still some data classes in the UI modules, but #55 will mark all those
as
ExperimentalWorkflowApibefore releasing 1.0.0.Fixes #57.