Introduce helpers for working with Sinks of WorkflowActions from suspend functions. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/collect-to-sink
branch
4 times, most recently
from
3d26c90
to
784bd7a
Compare
zach-klippenstein
changed the title
…end functions. - `Sink.sendAndAwaitApplication()` - `Flow.collectToSink()` These helpers will be used to implement Workers using side effects (#12). GUWT workers are described in square/workflow#1021.
zach-klippenstein
force-pushed
the
zachklipp/collect-to-sink
branch
from
784bd7a
to
505af7e
Compare
Comment on lines
+58
to
+63
| @Suppress("DEPRECATION") | ||
| @Deprecated("Implement Updater.apply") | ||
| fun Mutator<StateT>.apply(): OutputT? { | ||
| throw UnsupportedOperationException() | ||
| } | ||
|
|
There was a problem hiding this comment.
Moved this method below the non-deprecated one so that the non-deprecated one is what gets resolved for WorkflowAction.apply links in kdoc.
rjrjr
approved these changes
Jun 23, 2020
| * | ||
| * If this coroutine is cancelled before the action gets applied, the action will not be applied. | ||
| * | ||
| * This method is intended to be used from [RenderContext.runningSideEffect]. |
There was a problem hiding this comment.
Not sure what value a sample would add: there's really only one possible way to use this method.
| action: WorkflowAction<StateT, OutputT> | ||
| ) { | ||
| suspendCancellableCoroutine<Unit> { continuation -> | ||
| val resumingAction = action<StateT, OutputT>({ "sendAndAwaitExecution($action)" }) { |
There was a problem hiding this comment.
Nit: Don't you want the name to be sendAndAwaitApplication?
| @Test fun `collectToActionSink sends action`() { | ||
| runBlockingTest { | ||
| val flow = MutableStateFlow(1) | ||
| val collector = launch { |
There was a problem hiding this comment.
Nit: collector is slightly overloaded here given the coroutine context. Maybe sinkCollector? or collectorJob?
zach-klippenstein
added a commit
that referenced
this pull request
Feb 4, 2021
Make ViewFactory.showRendering function responsible for applying the ComposeViewFactoryRoot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sink.sendAndAwaitApplication()Flow.collectToSink()These helpers will be used to implement Workers using side effects (#12).
GUWT workers are described in square/workflow#1021.
Checklist
UI Tests