-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brings ViewStarter to the UI update. #620
Commits on Dec 9, 2021
-
View.launchWhenAttached tolerates strange ids
Fixes a problem where `launchWhenAttached` would crash if it failed to fetch a resource name when trying to make a cute scope name. I happen to know of some view systems that break our assumption that every id is named.
Configuration menu - View commit details
-
Copy full SHA for 5be01a5 - Browse repository at this point
Copy the full SHA 5be01a5View commit details -
Merge pull request #604 from square/ray/more-robust-ensureAttachedScope
View.launchWhenAttached tolerates strange ids
Configuration menu - View commit details
-
Copy full SHA for 757aa20 - Browse repository at this point
Copy the full SHA 757aa20View commit details
Commits on Dec 10, 2021
-
Fixes index out of bounds crash when attempting to add characters or …
…moving the cursor to the ends of the string being edited.
Configuration menu - View commit details
-
Copy full SHA for 5931b4a - Browse repository at this point
Copy the full SHA 5931b4aView commit details -
Merge pull request #605 from JsFlo/joseflores/terminalIndexOutOfBounds
Fixes index out of bounds crash in hello-todo-terminal sample
Configuration menu - View commit details
-
Copy full SHA for 821c7b6 - Browse repository at this point
Copy the full SHA 821c7b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e50052d - Browse repository at this point
Copy the full SHA e50052dView commit details -
Replaces *.initializeView with *.viewStarter
Fixes #597. It used to be the case that every `DecorativeViewFactory` called `showRendering()` twice (#397). We fixed that (we thought) by introducing the `initializeView` lambda to `ViewRegistry.buildView` and `DecorativeViewFactory` (#408). Unfortunately, that fix botched recursion. Individual `DecorativeViewFactory` instances work fine, but if you wrap them you still get one `showRendering` call from each. Worse, upstream `initializeView` lambdas are clobbered by immediately downstream ones. e.g., when a `WorkflowViewStub` shows a `DecorativeViewFactory`, the `WorkflowLifecycleRunner.installOn` call in the former is clobbered. The fix is to completely decouple building a view from from this kind of initialization. `ViewRegistry.buildView` and its wrappers no longer try to call `showRendering` at all. Instead the caller of `buildView` (mostly `WorkflowViewStub`) is reponsible for immediately calling `View.start` on the new `View`. `View.start` makes the initial `showRendering` call that formerly was the job of `ViewFactory.buildView` -- the factory builds the view, and the container turns the key. Since `View.start` is called only after all wrapped `ViewFactory.buildView` functions have executed, we're certain it will only happen once. Of course we still need the ability to customize view initialization via wrapping, especially to invoke `WorkflowLifecycleOwner.installOn`. To accomodate that, the function that `View.start` executes can be wrapped via the new `viewStarter` argument to `ViewRegistry.buildView` and `DecorativeViewFactory`, which replaces `initializeView`. This required a pretty thorough overhaul of `ViewShowRendering.kt` The `ViewShowRenderingTag` that it hangs off of a view tag is renamed `WorkflowViewState`, and extracted to a separate file. `WorkflowViewState` is a sealed class with two implementations (`New` and `Started`) to help us enforce the order of the `ViewRegistry.buildView`, `View.bindShowRendering`, `View.start` and `View.showRendering` calls.
Configuration menu - View commit details
-
Copy full SHA for b93a522 - Browse repository at this point
Copy the full SHA b93a522View commit details -
Merge pull request #602 from square/ray/initializeView-is-a-landmine
Replaces *.initializeView with *.viewStarter
Configuration menu - View commit details
-
Copy full SHA for df925e5 - Browse repository at this point
Copy the full SHA df925e5View commit details -
Because the [releases page](https://github.com/square/workflow-kotlin/releases) is so much nicer.
Configuration menu - View commit details
-
Copy full SHA for aeed829 - Browse repository at this point
Copy the full SHA aeed829View commit details -
Merge pull request #607 from square/ray/no-more-changelog
End CHANGELOG.md
Configuration menu - View commit details
-
Copy full SHA for 5cd4ba2 - Browse repository at this point
Copy the full SHA 5cd4ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d87bef1 - Browse repository at this point
Copy the full SHA d87bef1View commit details
Commits on Dec 13, 2021
-
When moving Workers to being wrapped by WorkerWorkflow we did not need to compare types included in the KType signature but that was not clear from the kdoc. Update that to make it clear.
Configuration menu - View commit details
-
Copy full SHA for 085e097 - Browse repository at this point
Copy the full SHA 085e097View commit details -
Merge pull request #609 from square/sedwards/608-typed-worker-compare…
…-output 608: Update TypedWorker kdoc
Configuration menu - View commit details
-
Copy full SHA for 9011f80 - Browse repository at this point
Copy the full SHA 9011f80View commit details
Commits on Dec 16, 2021
-
Use Gradle 7.3.2. Log4shell mitigation.
Gradle 7.3.2 adds dependency constraints to the _build_ classpath to reject known-bad versions of log4j. See also https://blog.gradle.org/log4j-vulnerability.
Configuration menu - View commit details
-
Copy full SHA for 42b6998 - Browse repository at this point
Copy the full SHA 42b6998View commit details -
Merge pull request #613 from autonomousapps/patch-1
Use Gradle 7.3.2. Log4shell mitigation.
Configuration menu - View commit details
-
Copy full SHA for 7c3bdb6 - Browse repository at this point
Copy the full SHA 7c3bdb6View commit details
Commits on Jan 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a80f9a0 - Browse repository at this point
Copy the full SHA a80f9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4844ad8 - Browse repository at this point
Copy the full SHA 4844ad8View commit details
Commits on Jan 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 588db3b - Browse repository at this point
Copy the full SHA 588db3bView commit details -
Merge pull request #617 from square/ralf/compile-sdk
Upgrade the compile SDK to 31.
Configuration menu - View commit details
-
Copy full SHA for a88141c - Browse repository at this point
Copy the full SHA a88141cView commit details -
Merge pull request #616 from square/ray/sonatype-update
Moves us to s01.oss.sonatype.org
Configuration menu - View commit details
-
Copy full SHA for e85d260 - Browse repository at this point
Copy the full SHA e85d260View commit details -
Merge remote-tracking branch 'origin/main' into ray/ui-update
* origin/main: Upgrade the compile SDK to 31. Moves us to s01.oss.sonatype.org Fixes version name after 1.3.0 release, forgot to bump it. Use Gradle 7.3.2. Log4shell mitigation. 608: Update TypedWorker kdoc Releasing v1.3.0 End CHANGELOG.md Replaces *.initializeView with *.viewStarter Adds (failing) DecorativeViewFactory double update test Fixes index out of bounds crash when attempting to add characters or moving the cursor to the ends of the string being edited. View.launchWhenAttached tolerates strange ids
Configuration menu - View commit details
-
Copy full SHA for a691e8e - Browse repository at this point
Copy the full SHA a691e8eView commit details
Commits on Jan 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f0dce22 - Browse repository at this point
Copy the full SHA f0dce22View commit details