View.launchWhenAttached tolerates strange ids #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a problem where `launchWhenAttached` would crash if it failed to fetch a resource name when trying to make a cute scope name. I happen to know of some view systems that break our assumption that every id is named.
Blisse
approved these changes
Dec 9, 2021
steve-the-edwards
approved these changes
Dec 9, 2021
|
I swear I'm going to have to turn off the 21 shard. Although this time it was maven failures. Gonna declare victory with the green 24 run and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where
launchWhenAttachedwould crash if it failed to fetch aresource name when trying to make a cute scope name. I happen to know of some
view systems that break our assumption that every id is named.