WIP Optimize rendering by caching renderings when possible. #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
changed the base branch from
zachklipp/single-leaf-benchmark
to
master
|
This makes the process of bubbling outputs up the tree slightly slower (have to call each parent to invalidate its rendering cache), so don't merge this until |
TODO: Need a benchmark that only updates one leaf, instead of all or none.
zach-klippenstein
force-pushed
the
zachklipp/cache-renderings
branch
from
028ff43
to
3a9027a
Compare
zach-klippenstein
added a commit
that referenced
this pull request
Jan 19, 2020
This looks like an optimization, but since most `onPropsChanged` are no-ops, it's not really. This is to prevent code from starting to rely on the fact that `onPropsChanged` is currently called on ever render pass. This is a small step towards the behavior in #803, which lets `WorkflowNode`s skip a render pass for their entire subtree when unnecessary. Making this change now will help prevent code from being written that will break when that change lands.
This was referenced Jan 19, 2020
|
Closing because inactive, might re-open later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spreadsheet
Note below the
renderPassAlternateOneLeaf | SQUAREcase – this is the most similar case to most real-world ones. A tree that is a little deep and a little bushy, where only one path some node up to the root actually updates and needs re-rendering. Here we only render 4 nodes, and all other renderings are simply returned from the cache.