Don't onPropsChanged unless the old and new props are actually unequal. #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like an optimization, but since most `onPropsChanged` are no-ops, it's not really. This is to prevent code from starting to rely on the fact that `onPropsChanged` is currently called on ever render pass. This is a small step towards the behavior in #803, which lets `WorkflowNode`s skip a render pass for their entire subtree when unnecessary. Making this change now will help prevent code from being written that will break when that change lands.
|
Should manually test the Dungeon sample and make sure the time machine still works. |
kirillzh
approved these changes
Jan 20, 2020
rjrjr
approved these changes
Jan 21, 2020
| ) | ||
|
|
||
| propsChannel.send("new props") | ||
| yield() |
There was a problem hiding this comment.
Will follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like an optimization, but since most
onPropsChangedare no-ops,it's not really. This is to prevent code from starting to rely on the fact
that
onPropsChangedis currently called on ever render pass. This is a smallstep towards the behavior in #803, which lets
WorkflowNodes skip a renderpass for their entire subtree when unnecessary. Making this change now will
help prevent code from being written that will break when that change lands.
The actual change is just surrounding three lines with an if, most of the changes in this PR are updates to tests.