Convert list type to tuple in frozen classes (Fixes #117) #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houston/mission.py
Outdated
| @@ -20,21 +20,21 @@ class Mission(object): | |||
| configuration = attr.ib(type=Configuration) | |||
| environment = attr.ib(type=Environment) | |||
| initial_state = attr.ib(type=State) | |||
| commands = attr.ib(type=List[Command]) # FIXME | |||
| commands = attr.ib(type=Tuple[Command]) # FIXME | |||
There was a problem hiding this comment.
Use a converter to transform a list (or tuple) into a tuple.
See: http://www.attrs.org/en/stable/init.html#converters
There was a problem hiding this comment.
Nice. I didn't know that exists.
| @@ -167,15 +167,15 @@ def generate_with_se(sut, initial, environment, config, mission): | |||
| sut = houston.ardu.ArduCopter(snapshot, config) | |||
|
|
|||
| # mission description | |||
| cmds = [ | |||
| cmds = ( | |||
There was a problem hiding this comment.
Minor point: It should be possible to pass a list to the constructor; the constructor should transform the list into a tuple.
houston/mission.py
Outdated
| @@ -20,21 +21,22 @@ class Mission(object): | |||
| configuration = attr.ib(type=Configuration) | |||
| environment = attr.ib(type=Environment) | |||
| initial_state = attr.ib(type=State) | |||
| commands = attr.ib(type=List[Command]) # FIXME | |||
| commands = attr.ib(type=Union[List[Command], Tuple[Command]], | |||
There was a problem hiding this comment.
The type property specifies the type of the values that are used by that attribute. To avoid misleading the static analysis, type should be Tuple[Command] in this case.
ChrisTimperley
requested changes
Oct 4, 2018
houston/mission.py
Outdated
| @@ -72,13 +74,14 @@ class MissionOutcome(object): | |||
| a mission. | |||
| """ | |||
| passed = attr.ib(type=bool) | |||
| outcomes = attr.ib(type=List[CommandOutcome]) | |||
| outcomes = attr.ib(type=Union[List[CommandOutcome], Tuple[CommandOutcome]], | |||
ChrisTimperley
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.