Use apiextension v1 #186
Merged
Use apiextension v1 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will update the e2e tests in a follow up. Mainly because I would like to write something like but the yaml manifest is not present in the main branch yet. EDIT: nvm, kg crashes without the crd |
leonnicolas
force-pushed
the
crd_validation
branch
from
0917a57
to
30f6311
Compare
squat
reviewed
Jun 14, 2021
squat
reviewed
Jun 14, 2021
Makefile
Outdated
| @@ -75,7 +76,13 @@ all-container-latest: $(addprefix container-latest-, $(ALL_ARCH)) | |||
|
|
|||
| all-push-latest: $(addprefix push-latest-, $(ALL_ARCH)) | |||
|
|
|||
| generate: client deepcopy informer lister openapi | |||
| generate: client deepcopy informer lister openapi crd | |||
There was a problem hiding this comment.
Suggested change
| generate: client deepcopy informer lister openapi crd | |
| generate: client deepcopy informer lister crd |
squat
reviewed
Jun 14, 2021
Makefile
Outdated
| @@ -120,6 +127,17 @@ pkg/k8s/informers/kilo/v1alpha1/peer.go: .header pkg/k8s/apis/kilo/v1alpha1/type | |||
| rm -r github.com || true | |||
| go fmt ./pkg/k8s/informers/... | |||
|
|
|||
| openapi: pkg/k8s/apis/kilo/v1alpha1/openapi_generated.go | |||
squat
reviewed
Jun 14, 2021
Makefile
Outdated
| @@ -1,5 +1,5 @@ | |||
| export GO111MODULE=on | |||
| .PHONY: push container clean container-name container-latest push-latest fmt lint test unit vendor header generate client deepcopy informer lister openapi manifest manfest-latest manifest-annotate manifest manfest-latest manifest-annotate release gen-docs e2e | |||
| .PHONY: push container clean container-name container-latest push-latest fmt lint test unit vendor header generate openapi crd client deepcopy informer lister manifest manfest-latest manifest-annotate manifest manfest-latest manifest-annotate release gen-docs e2e | |||
There was a problem hiding this comment.
Suggested change
| .PHONY: push container clean container-name container-latest push-latest fmt lint test unit vendor header generate openapi crd client deepcopy informer lister manifest manfest-latest manifest-annotate manifest manfest-latest manifest-annotate release gen-docs e2e | |
| .PHONY: push container clean container-name container-latest push-latest fmt lint test unit vendor header generate crd client deepcopy informer lister manifest manfest-latest manifest-annotate manifest manfest-latest manifest-annotate release gen-docs e2e |
squat
reviewed
Jun 14, 2021
leonnicolas
force-pushed
the
crd_validation
branch
from
30f6311
to
da24b5e
Compare
squat
reviewed
Jun 14, 2021
tools.go
Outdated
| @@ -24,4 +24,5 @@ import ( | |||
| _ "k8s.io/code-generator/cmd/informer-gen" | |||
| _ "k8s.io/code-generator/cmd/lister-gen" | |||
| _ "k8s.io/kube-openapi/cmd/openapi-gen" | |||
There was a problem hiding this comment.
Suggested change
| _ "k8s.io/kube-openapi/cmd/openapi-gen" |
There was a problem hiding this comment.
I think this is the last thing, then make vendor
- upgrade from apiextension v1beta1 to v1 - generate yaml manifest for crd intead of applying it at runtime - users will have to apply the manifest with kubectl - kg and kgctl log an error if the crd is not present - now validation should actually work Signed-off-by: leonnicolas <leonloechner@gmx.de>
leonnicolas
force-pushed
the
crd_validation
branch
from
da24b5e
to
36643b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: leonnicolas leonloechner@gmx.de