-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nvidia compatibility matrix #23
Conversation
nvidia/daemonset.yaml
Outdated
@@ -17,12 +17,12 @@ spec: | |||
spec: | |||
hostPID: true | |||
initContainers: | |||
- image: squat/modulus:4c946362b8267c4680618c39489d873ed386f807 | |||
- image: squat/modulus:6af521a148f51e164764de716da0b30769c57083 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump this now that #22 is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- image: squat/modulus:6af521a148f51e164764de716da0b30769c57083 | |
- image: squat/modulus:85f9128a80cf47adea85fc008b8c2dcbfad6da86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@squat Good shout, done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️❤️❤️
9a8d9e7
to
a50704c
Compare
Thanks again for such a great tool! FYI I tried using Flatcar's native solution but I couldn't get it working so this project is still the best (and only) solution I am aware of: https://www.flatcar.org/docs/latest/setup/customization/using-nvidia/
This PR upgrades the Nvidia module version to what I have tested on my own cluster and finally closed off the following issue by creating a compatibility matrix (not sure if there is a better place/format to use though): #19
Also, using the DaemonSet image in the main branch didn't work for me (see logs below) but it did work building my own image:
docker buildx build --platform linux/amd64 --push -t dippynark/modulus:custom .
So I updated the tag to the latest commit.
I also needed the following PR for a successful build: #22
Error logs for image
squat/modulus:4c946362b8267c4680618c39489d873ed386f807
: