Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometime, resin is quite infrequent. #30

Closed
kane-thornwyrd opened this issue Aug 27, 2015 · 18 comments
Closed

Sometime, resin is quite infrequent. #30

kane-thornwyrd opened this issue Aug 27, 2015 · 18 comments

Comments

@kane-thornwyrd
Copy link

Hello Squeek,

I made some tests, and in the case people use TConstruct the resin drops are really rare, like once in 10 trees, if Treecapitator is also in use, resin become rarer than diamond, literally.

I don't know which stand you will take about this, but my advice would be to totally avoid the issue by adding a resin collector like what Electrical Age guys do:

Electrical Age Repo
Resin Collector

Or even IC² with their resin tap.

Thank you for your attention :)

@squeek502
Copy link
Owner

Interesting. I would have thought that the drops would be compatible with things like lumber axes/treecapitator. I'll make sure to test that and see if anything's going wrong.

I like that resin collector solution, though.

@kane-thornwyrd kane-thornwyrd changed the title [mod integration][design/balance][enhancement] Sometime, resin is quite infrequent. Sometime, resin is quite infrequent. Aug 27, 2015
@kane-thornwyrd
Copy link
Author

I honestly think that the bug is on their side, because at the end of the day they are those whom implemented their own "felling algorithm" that doesn't seems to fire HarvestDropsEvent for each blocks chopped.

@squeek502
Copy link
Owner

Right, that's what I thought as well, but it looks like the TCon code should work. From here it calls the vanilla method block.harvestBlock(world, player, x,y,z, meta);, which does fire the HarvestDropsEvent.

Once I am able to test it, I'll set the drop chance of resin to 100% and see if it drops the correct amount.

@squeek502
Copy link
Owner

TCon Lumber Axes seems to work as expected for me. When I set the drop chance to 100%, I got 6 resin and 6 spruce wood when I chopped down a tree.

Perhaps you just got unlucky? How did you test it?

@kane-thornwyrd
Copy link
Author

True, it's strange it's so rare with only TC though. 😕
And Treecapitator, just not....
Anyway, imho this part of the problem is still not your concern, I'll ask Bspkrs if he use a trick to anyway fire this event.

@squeek502
Copy link
Owner

Do you have stackDrops set to true in your Treecapitator config? Looks like that's the only setting that'd bypass the HarvestDropsEvent being fired.

EDIT: Relevant code for Treecapitator for reference: https://github.com/bspkrs/Treecapitator/blob/1.7.10/src/main/java/bspkrs/treecapitator/Treecapitator.java#L605-L610

@kane-thornwyrd
Copy link
Author

Answer to your question
I have been unlucky then, protocol:

  • flatworld of 49:8 blocks with a block replaced by dirt.
  • gamemode 0
  • Manyullyn lumber axe.
  • a lot of spruce sapplings.
  • a lot of bonemeal.
  • Testbed modpack 1.7.10 :
    • Admin Command Toolbox
    • Aroma1997Core
    • AromaBackup
    • CodeChickenCore
    • InvTweak
    • NEI
    • NEKeys
    • NEResources
    • Waila
    • Waila Harvestability
  • Tested mods:
    • The Vegan Option
    • Mantle
    • TConstruct

I'll write down the test of a batch of 50 trees here, plus you gave me the idea to submit my "testbed modpack" as reference.

@kane-thornwyrd
Copy link
Author

Ooooh, okay 😓

@squeek502
Copy link
Owner

I'll submit a bug report on the Treecapitator issue tracker. It's something that would be good to get fixed.

@kane-thornwyrd
Copy link
Author

Thank you A LOT !

@kane-thornwyrd
Copy link
Author

For now on, I'll use this modpack to test, as a "stable base".
BTW, You're credited 😉

@kane-thornwyrd
Copy link
Author

Results time: for 64 trees, I got 36 resin using the TConstruct lumber axe.

I may have found an exploit too.

@squeek502
Copy link
Owner

Is the exploit that you can break a spruce block, place it back down, break it again, get resin again, and repeat? If so, I am aware but am not quite sure how to fix it yet.

@kane-thornwyrd
Copy link
Author

yes, but don't worry too much, to become really "fun" those who want to use it should make some serious redstone first ^^

@ghost
Copy link

ghost commented Nov 9, 2015

I've noticed the same with Rotarycraft woodcutter and bedrock axe.

@squeek502
Copy link
Owner

@reteo same problem as Treecapitator. Adding a resin collector is looking better and better.

@ReikaKalseki
Copy link

The bedrock axe is not. It does not use BlockArray (though it used to). Instead it uses a TickHandler, ProgressiveRecursiveBreaker.

@squeek502
Copy link
Owner

I guess that means that ProgressiveRecursiveBreaker needs HarvestDropsEvent support as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants