Fix eCAP header includes #1753
Closed
Fix eCAP header includes #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
yadij
commented
Mar 23, 2024
Comment on lines
+910
to
+911
| /* libecap-1.0.1 headers do not build without autoconf.h magic */ | ||
| #define HAVE_CONFIG_H |
There was a problem hiding this comment.
libecap apparently lacks basic self-consistency checks for its installed headers.
AC_CHECK_HEADERS exposes
/usr/include/libecap/common/registry.h:15:75: error: 'LIBECAP_VERSION' was not declared in this scope
15 | extern bool RegisterVersionedService(adapter::Service *s, const char *v = LIBECAP_VERSION);
yadij
commented
Mar 23, 2024
| ],,,[ | ||
| /* libecap-1.0.1 headers do not build without autoconf.h magic */ | ||
| #define HAVE_CONFIG_H | ||
| /* libecap/common/delay.h fails to include <string> */ |
There was a problem hiding this comment.
libecap apparently lacks basic self-consistency checks for its installed headers.
AC_CHECK_HEADERS exposes a number of identical std::string errors, one example:
/usr/include/libecap/common/delay.h:15:43: error: 'string' in namespace 'std' does not name a type
15 | explicit Delay(const std::string &state_):
| ^~~~~~
/usr/include/libecap/common/delay.h:7:1: note: 'std::string' is defined in header '<string>'; this is probably fixable by adding '#include <string>'
|
May I assume that after this PR, build issues are solved? |
|
Yes the commented lines are all that is necessary. These issues do no appear during the main build because we are an autoconf project and other files include |
What build issues? PR description does not mention any fixed build issues, and the PR has only one commit. What am I missing? |
The code comments documenting why the |
I was aware of those comments when I asked the question. I am interpreting your response as "The 'build issues' Francesco is talking about are not present in master/v7 code". Please correct me if I am wrong. |
rousskov
added
the
S-waiting-for-author
squid-anubis
pushed a commit
that referenced
this pull request
Apr 2, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
squid-anubis
added
M-waiting-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Apr 2, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
squid-anubis
added
M-waiting-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Apr 3, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
squid-anubis
added
M-waiting-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Apr 4, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
squid-anubis
added
M-waiting-staging-checks
yadij
added
M-cleared-for-merge
squid-anubis
added
M-abandoned-staging-checks
|
Marking for merge under the 10+ day criteria. |
squid-anubis
removed
the
M-abandoned-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Apr 5, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Apr 9, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Apr 9, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Apr 14, 2024
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squid style guidelines require .h files to be wrapped with
HAVE_*_H protection and placed after all Squid internal file
includes.
Add the missing ./configure header checks to generate the
needed wrappers and refactor the include sequences to meet
current guidelines.