Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE #1774

Closed
wants to merge 6 commits into from
Closed

Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE #1774

wants to merge 6 commits into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Apr 5, 2024 •
edited

Removing a lot of duplicated code and further
simplifying library detection.

kinkie
kinkie previously approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@kinkie kinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@squid-anubis squid-anubis added M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 5, 2024
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Apr 5, 2024
rousskov
rousskov requested changes Apr 5, 2024
View reviewed changes
acinclude/squid-util.m4 Show resolved Hide resolved
acinclude/squid-util.m4 Show resolved Hide resolved
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Apr 5, 2024
@yadij yadij added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Apr 5, 2024
@yadij yadij requested a review from rousskov April 5, 2024 18:00
rousskov
rousskov requested changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

acinclude/squid-util.m4 Outdated Show resolved Hide resolved
acinclude/squid-util.m4 Outdated Show resolved Hide resolved
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Apr 6, 2024
yadij and others added 3 commits April 7, 2024 23:34
@yadij @rousskov
Update acinclude/squid-util.m4
869ece6 
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
@yadij @rousskov
Update acinclude/squid-util.m4
5a50c69 
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
@yadij
Merge branch 'master' into arc-autoconf-ng-40
506e940
@yadij yadij requested a review from rousskov April 7, 2024 11:34
@yadij yadij added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Apr 7, 2024
@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Apr 7, 2024
squid-anubis pushed a commit that referenced this pull request Apr 7, 2024
@yadij @squid-anubis
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (#1774)
597b7f1 
Removing a lot of duplicated code and further
simplifying library detection.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Apr 7, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 7, 2024
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 9, 2024
@yadij @kinkie
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (squid-cache#1774)
ac9be5a 
Removing a lot of duplicated code and further
simplifying library detection.
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 9, 2024
@yadij @kinkie
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (squid-cache#1774)
0961747 
Removing a lot of duplicated code and further
simplifying library detection.
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 9, 2024
@yadij @kinkie
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (squid-cache#1774)
6105648 
Removing a lot of duplicated code and further
simplifying library detection.
@yadij yadij deleted the arc-autoconf-ng-40 branch April 10, 2024 11:31
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 14, 2024
@yadij @kinkie
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (squid-cache#1774)
4ad2798 
Removing a lot of duplicated code and further
simplifying library detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

@kinkie kinkie kinkie left review comments

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
4 participants
@yadij @rousskov @kinkie @squid-anubis