Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply ALE with HttpReply before checking http_reply_access #398

Commits on May 2, 2019

  1. Supply ALE with HttpReply before checking http_reply_access

    Before this fix, Squid warned that "ALE missing HttpReply object",
    because ALE::reply was initialized too late. This problem affected
    both HTTP and FTP code paths.
    eduard-bagdasaryan committed May 2, 2019
    Configuration menu
    Copy the full SHA
    be6c958 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Use ALE::setReply() for ALE::reply assigment

    With this change, it is now impossible to directly assign public
    ALE::reply field. Another approach is to make this field private, but it
    would require many out-of-scope changes.
    eduard-bagdasaryan committed May 3, 2019
    Configuration menu
    Copy the full SHA
    1ce7574 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Fixed unit tests

    eduard-bagdasaryan committed May 4, 2019
    Configuration menu
    Copy the full SHA
    3461984 View commit details
    Browse the repository at this point in the history
  2. Check ALE for nil before setting the reply field

    ... since FwdState::al may be nil sometimes and it is difficult to
    predict whether these situations are possible in the two affected
    places.
    eduard-bagdasaryan committed May 4, 2019
    Configuration menu
    Copy the full SHA
    57aabda View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Configuration menu
    Copy the full SHA
    a79cdca View commit details
    Browse the repository at this point in the history
  2. Converted ALE::reply to HttpReplyPointer

    This is probably a safer way to handle locking/unlocking
    of this member compared to the setReply() method.
    eduard-bagdasaryan committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    c5aaabc View commit details
    Browse the repository at this point in the history
  3. Revert "Fixed unit tests"

    This reverts commit 3461984.
    eduard-bagdasaryan committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    43f7d5f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be1da33 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Configuration menu
    Copy the full SHA
    67448b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    854c634 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. 1 Configuration menu
    Copy the full SHA
    53a8826 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Several fixes

    * Fixed comments and documentation according to the wiki
      'response terminology'.
    
    * Initialize http->al->reply just after clone(), in order to supply
      it to early ACLs checks called during building the final response
      header (e.g., reply_header_add ACLs).
    eduard-bagdasaryan committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    824da98 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Supply ALE with HttpReply as early as possible

    After be6c958 ALE was supplied with 'sent' HttpReply, and many (but not
    all) ACL checks could use it. Earlier directives, such as
    adaptation_access and store_miss still lacked it. To resolve this, we
    need ALE::reply to point to the reply available at the moment, starting
    with the virgin reply.
    
    Also fixed ALE::reply for all 1xx (control) messages. Though be6c958
    adjusted it for control responses coming from the origin, it missed
    self-generated control responses (force_request_body_continuation
    directive).
    eduard-bagdasaryan committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0eda4cf View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Supply ALE for send_hit ACL

    cb36505 already covered many (but not all) similar cases.
    eduard-bagdasaryan committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    01703cf View commit details
    Browse the repository at this point in the history
  2. Fix '<h' for control (1xx) responses

    When applying '<h' format code in Format::assemble(), two different
    sources are used: ALE::headers::reply for all headers and ALE::reply for
    specific headers. This unfortunate approach of storing one entity in two
    different places caused problems with logging 1xx responses:
    ALE::headers::reply remained uninitialized.
    
    Also, even before this PR changes, the ALE::headers::reply string was
    initialized too early with the adapted reply, while ALE::reply contained
    the sent reply. Now these two fields are assigned synchronously.
    However,  this does not protect from loosing synchronization when
    ALE::reply is modified.
    
    Also fixed '<h' to log headers without status line, which looks wrong:
    
    * It does not correlate withe the similar '>h', which loggs just request
      headers
    
    * Status code can/should be logged with a dedicated '<Hs' format code.
    eduard-bagdasaryan committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    fdf6662 View commit details
    Browse the repository at this point in the history
  3. Log with '<h' actual reply headers instead of a cached header string

    ... thus addressing an XXX added at fdf6662. Instead of keeping the
    string copy of the reply headers up-to-date (and risking loosing
    synchronization on a modification) I think it is better to generate
    it only when it is used.
    eduard-bagdasaryan committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    d513678 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Polishing

    eduard-bagdasaryan committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    dc453ae View commit details
    Browse the repository at this point in the history
  2. Partially undone fdf6662

    Restored the old behavior for '<h', logging both statusline and headers.
    eduard-bagdasaryan committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    7a96f97 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Configuration menu
    Copy the full SHA
    cc860b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e7eb49 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Configuration menu
    Copy the full SHA
    5f8055f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78ca607 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Configuration menu
    Copy the full SHA
    7bd1b13 View commit details
    Browse the repository at this point in the history
  2. Polished

    eduard-bagdasaryan committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    3318fe2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Configuration menu
    Copy the full SHA
    064bf97 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Polishing

    eduard-bagdasaryan committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    8cd9b08 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Configuration menu
    Copy the full SHA
    766df68 View commit details
    Browse the repository at this point in the history