-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply ALE with HttpReply before checking http_reply_access #398
Supply ALE with HttpReply before checking http_reply_access #398
Commits on May 2, 2019
-
Supply ALE with HttpReply before checking http_reply_access
Before this fix, Squid warned that "ALE missing HttpReply object", because ALE::reply was initialized too late. This problem affected both HTTP and FTP code paths.
Configuration menu - View commit details
-
Copy full SHA for be6c958 - Browse repository at this point
Copy the full SHA be6c958View commit details
Commits on May 3, 2019
-
Use ALE::setReply() for ALE::reply assigment
With this change, it is now impossible to directly assign public ALE::reply field. Another approach is to make this field private, but it would require many out-of-scope changes.
Configuration menu - View commit details
-
Copy full SHA for 1ce7574 - Browse repository at this point
Copy the full SHA 1ce7574View commit details
Commits on May 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3461984 - Browse repository at this point
Copy the full SHA 3461984View commit details -
Check ALE for nil before setting the reply field
... since FwdState::al may be nil sometimes and it is difficult to predict whether these situations are possible in the two affected places.
Configuration menu - View commit details
-
Copy full SHA for 57aabda - Browse repository at this point
Copy the full SHA 57aabdaView commit details
Commits on Jul 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a79cdca - Browse repository at this point
Copy the full SHA a79cdcaView commit details -
Converted ALE::reply to HttpReplyPointer
This is probably a safer way to handle locking/unlocking of this member compared to the setReply() method.
Configuration menu - View commit details
-
Copy full SHA for c5aaabc - Browse repository at this point
Copy the full SHA c5aaabcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43f7d5f - Browse repository at this point
Copy the full SHA 43f7d5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for be1da33 - Browse repository at this point
Copy the full SHA be1da33View commit details
Commits on Jul 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 67448b6 - Browse repository at this point
Copy the full SHA 67448b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 854c634 - Browse repository at this point
Copy the full SHA 854c634View commit details
Commits on Jul 22, 2019
-
1
Configuration menu - View commit details
-
Copy full SHA for 53a8826 - Browse repository at this point
Copy the full SHA 53a8826View commit details
Commits on Jul 25, 2019
-
* Fixed comments and documentation according to the wiki 'response terminology'. * Initialize http->al->reply just after clone(), in order to supply it to early ACLs checks called during building the final response header (e.g., reply_header_add ACLs).
Configuration menu - View commit details
-
Copy full SHA for 824da98 - Browse repository at this point
Copy the full SHA 824da98View commit details
Commits on Jul 31, 2019
-
Supply ALE with HttpReply as early as possible
After be6c958 ALE was supplied with 'sent' HttpReply, and many (but not all) ACL checks could use it. Earlier directives, such as adaptation_access and store_miss still lacked it. To resolve this, we need ALE::reply to point to the reply available at the moment, starting with the virgin reply. Also fixed ALE::reply for all 1xx (control) messages. Though be6c958 adjusted it for control responses coming from the origin, it missed self-generated control responses (force_request_body_continuation directive).
Configuration menu - View commit details
-
Copy full SHA for 0eda4cf - Browse repository at this point
Copy the full SHA 0eda4cfView commit details
Commits on Aug 1, 2019
-
cb36505 already covered many (but not all) similar cases.
Configuration menu - View commit details
-
Copy full SHA for 01703cf - Browse repository at this point
Copy the full SHA 01703cfView commit details -
Fix '<h' for control (1xx) responses
When applying '<h' format code in Format::assemble(), two different sources are used: ALE::headers::reply for all headers and ALE::reply for specific headers. This unfortunate approach of storing one entity in two different places caused problems with logging 1xx responses: ALE::headers::reply remained uninitialized. Also, even before this PR changes, the ALE::headers::reply string was initialized too early with the adapted reply, while ALE::reply contained the sent reply. Now these two fields are assigned synchronously. However, this does not protect from loosing synchronization when ALE::reply is modified. Also fixed '<h' to log headers without status line, which looks wrong: * It does not correlate withe the similar '>h', which loggs just request headers * Status code can/should be logged with a dedicated '<Hs' format code.
Configuration menu - View commit details
-
Copy full SHA for fdf6662 - Browse repository at this point
Copy the full SHA fdf6662View commit details -
Log with '<h' actual reply headers instead of a cached header string
... thus addressing an XXX added at fdf6662. Instead of keeping the string copy of the reply headers up-to-date (and risking loosing synchronization on a modification) I think it is better to generate it only when it is used.
Configuration menu - View commit details
-
Copy full SHA for d513678 - Browse repository at this point
Copy the full SHA d513678View commit details
Commits on Aug 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dc453ae - Browse repository at this point
Copy the full SHA dc453aeView commit details -
Restored the old behavior for '<h', logging both statusline and headers.
Configuration menu - View commit details
-
Copy full SHA for 7a96f97 - Browse repository at this point
Copy the full SHA 7a96f97View commit details
Commits on Aug 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cc860b2 - Browse repository at this point
Copy the full SHA cc860b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e7eb49 - Browse repository at this point
Copy the full SHA 1e7eb49View commit details
Commits on Aug 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5f8055f - Browse repository at this point
Copy the full SHA 5f8055fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ca607 - Browse repository at this point
Copy the full SHA 78ca607View commit details
Commits on Aug 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7bd1b13 - Browse repository at this point
Copy the full SHA 7bd1b13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3318fe2 - Browse repository at this point
Copy the full SHA 3318fe2View commit details
Commits on Aug 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 064bf97 - Browse repository at this point
Copy the full SHA 064bf97View commit details
Commits on Aug 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8cd9b08 - Browse repository at this point
Copy the full SHA 8cd9b08View commit details
Commits on Sep 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 766df68 - Browse repository at this point
Copy the full SHA 766df68View commit details