Bug 4842: Memory leak when http_reply_access uses external_acl #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACL code updates the AccessLogEntry::reply member when an acl which is requires the ALE, like the external acls, is used. Later the Http::One::Server::handleReply member updates again the same ALE member without checking if it is already set. This is a Measurement Factory project
squid-anubis
added
the
M-failed-description
rousskov
changed the title
squid-anubis
removed
the
M-failed-description
yadij
approved these changes
Jun 29, 2019
yadij
added
the
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Jun 29, 2019
Http::One::Server::handleReply() sets AccessLogEntry::reply which may already be set. It is already set, for example, when the ACL code has already called syncAle() because external ACLs require an ALE. This bug was introduced by commit fbbea66. This is a Measurement Factory project.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jul 4, 2019
…-cache#424) Http::One::Server::handleReply() sets AccessLogEntry::reply which may already be set. It is already set, for example, when the ACL code has already called syncAle() because external ACLs require an ALE. This bug was introduced by commit fbbea66. This is a Measurement Factory project.
yadij
pushed a commit
that referenced
this pull request
Jul 4, 2019
Http::One::Server::handleReply() sets AccessLogEntry::reply which may already be set. It is already set, for example, when the ACL code has already called syncAle() because external ACLs require an ALE. This bug was introduced by commit fbbea66. This is a Measurement Factory project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http::One::Server::handleReply() sets AccessLogEntry::reply which may
already be set. It is already set, for example, when the ACL code
has already called syncAle() because external ACLs require an ALE.
This bug was introduced by commit fbbea66.
This is a Measurement Factory project.