Fix inline line highlight padding, wrapping, and gutter background #1501
Conversation
- Line highlight pad should match the parent - Float the gutter left to force code and numbers not to wrap - Provide a background for the gutter
|
How do you want to handle the coloring of the gutter background? I basically eye balled it, but it would be nice to derive it |
|
Deploy preview for mkdocs-material-preview ready! Built with commit 3d40a65 https://deploy-preview-1501--mkdocs-material-preview.netlify.com |
That is a good question, as the code background has alpha transparency which will not have the intended effect when used on the line numbers. I think we should switch to an opaque background. I removed code background in admonition titles in a recent commit, so I think the transparency is of no use anymore, or am I missing something? |
|
Results:
|
|
Thanks for providing the visual aid. Unfortunately the gutter doesn't match the background color, but that should be resolved when switching to opaque colors and CSS variables. |
|
Root level, stretched code blocks use a different padding, so we have to stretch the highlighting differently for this that case as well. Last commit accounts for this case. |
|
Sorry for the churn, but I think I got them all:
|
|
LGTM, thanks for taking the time to investigate and fix this! |
Fixes #1499