Change url to relative scheme #84
Conversation
This fixes the problem with Chrome (and others?) can't run the script on HTTPS-sites. The certificate is not valid but it works anyway.
| @@ -124,7 +124,7 @@ <h2 class="screen-hide">WCAG 2.0 Bookmarklet</h2> | |||
| </script> | |||
|
|
|||
| <div class="button" onclick="alert('Drag this to your browser Bookmarks Bar to install. Once installed, you can run the WCAG Bookmarklet over any page.'); return false;"> | |||
| <a id="add-bookmarklet" onmousedown="_gaq.push(['_trackEvent', 'Viper', 'bookmarklet.clicked']);" href="javascript:(function() {var _p='http://squizlabs.github.io/HTML_CodeSniffer/build/';var _i=function(s,cb) {var sc=document.createElement('script');sc.onload = function() {sc.onload = null;sc.onreadystatechange = null;cb.call(this);};sc.onreadystatechange = function(){if(/^(complete|loaded)$/.test(this.readyState) === true){sc.onreadystatechange = null;sc.onload();}};sc.src=s;if (document.head) {document.head.appendChild(sc);} else {document.getElementsByTagName('head')[0].appendChild(sc);}}; var options={path:_p};_i(_p+'HTMLCS.js',function(){HTMLCSAuditor.run('WCAG2AA',null,options);});})();"><span class="screen-hide">HTML_CodeSniffer</span></a> | |||
| <a id="add-bookmarklet" onmousedown="_gaq.push(['_trackEvent', 'Viper', 'bookmarklet.clicked']);" href="javascript:(function() {var _p='//squizlabs.github.io/HTML_CodeSniffer/build/';var _i=function(s,cb) {var sc=document.createElement('script');sc.onload = function() {sc.onload = null;sc.onreadystatechange = null;cb.call(this);};sc.onreadystatechange = function(){if(/^(complete|loaded)$/.test(this.readyState) === true){sc.onreadystatechange = null;sc.onload();}};sc.src=s;if (document.head) {document.head.appendChild(sc);} else {document.getElementsByTagName('head')[0].appendChild(sc);}}; var options={path:_p};_i(_p+'HTMLCS.js',function(){HTMLCSAuditor.run('WCAG2AA',null,options);});})();"><span class="screen-hide">HTML_CodeSniffer</span></a> | |||
There was a problem hiding this comment.
Yes it does; https://squizlabs.github.io/HTML_CodeSniffer/build/HTMLCS.js
Invalid cert but chrome wont complain when loading the bookmark.
There was a problem hiding this comment.
Works fine, invalid cert tho, but chrome doesn't care about that.
On 8 nov 2013, at 16:19, Nick Schonning notifications@github.com wrote:
In index.html:
@@ -124,7 +124,7 @@
WCAG 2.0 Bookmarklet
</script><div class="button" onclick="alert('Drag this to your browser Bookmarks Bar to install. Once installed, you can run the WCAG Bookmarklet over any page.'); return false;">
<a id="add-bookmarklet" onmousedown="_gaq.push(['_trackEvent', 'Viper', 'bookmarklet.clicked']);" href="javascript:(function() {var _p='http://squizlabs.github.io/HTML_CodeSniffer/build/';var _i=function(s,cb) {var sc=document.createElement('script');sc.onload = function() {sc.onload = null;sc.onreadystatechange = null;cb.call(this);};sc.onreadystatechange = function(){if(/^(complete|loaded)$/.test(this.readyState) === true){sc.onreadystatechange = null;sc.onload();}};sc.src=s;if (document.head) {document.head.appendChild(sc);} else {document.getElementsByTagName('head')[0].appendChild(sc);}}; var options={path:_p};_i(_p+'HTMLCS.js',function(){HTMLCSAuditor.run('WCAG2AA',null,options);});})();"><span class="screen-hide">HTML_CodeSniffer</span></a><a id="add-bookmarklet" onmousedown="_gaq.push(['_trackEvent', 'Viper', 'bookmarklet.clicked']);" href="javascript:(function() {var _p='//squizlabs.github.io/HTML_CodeSniffer/build/';var _i=function(s,cb) {var sc=document.createElement('script');sc.onload = function() {sc.onload = null;sc.onreadystatechange = null;cb.call(this);};sc.onreadystatechange = function(){if(/^(complete|loaded)$/.test(this.readyState) === true){sc.onreadystatechange = null;sc.onload();}};sc.src=s;if (document.head) {document.head.appendChild(sc);} else {document.getElementsByTagName('head')[0].appendChild(sc);}}; var options={path:_p};_i(_p+'HTMLCS.js',function(){HTMLCSAuditor.run('WCAG2AA',null,options);});})();"><span class="screen-hide">HTML_CodeSniffer</span></a>—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
You can force the browser to ignore the cert error manually, but id doesn't work loading as a resource. Try the following
<!DOCTYPE html>
<html lang="en">
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<meta charset="utf-8">
<title>HTTPS Test</title>
<script src="https://squizlabs.github.io/HTML_CodeSniffer/build/HTMLCS.js"></script>
</head>
<body>
Test HTTPS
</body>
</html>There was a problem hiding this comment.
Damn you're right guys, I've must have accepted the certificate in the same browser session, that way it works.
Ive also contacted github support had they said they have no plans to support https, too bad since they only had to buy a valid cert.
|
Although GitHub Pages does not officially support HTTPS, the certificate they are now using includes *.github.io in the domains the certificate supports. So, going to merge this in. Thanks for the report and pull request! |
Change url to relative scheme, now GitHub's SSL cert supports github.io
This fixes the problem with Chrome (and others?) can't run the script on HTTPS-sites. The certificate is not valid but it works anyway.