Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squiz.Scope.MemberVarScope does not work for multiline member declaration #1963

Closed
umherirrender opened this issue Mar 23, 2018 · 1 comment · Fixed by #1964
Closed

Squiz.Scope.MemberVarScope does not work for multiline member declaration #1963

umherirrender opened this issue Mar 23, 2018 · 1 comment · Fixed by #1964
Milestone

Comments

@umherirrender
Copy link

In case of the following member declaration

public $mCounter, $mSearchUser, $mSearchPeriodStart, $mSearchPeriodEnd,
	$mTestFilter;

phpcs outputs

FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
   | ERROR | Scope modifier not specified for member variable
   |       | "$mTestFilter" (Squiz.Scope.MemberVarScope.Missing)
----------------------------------------------------------------------

But $mTestFilter has the public visibility and should not be reported.

@jrfnl
Copy link
Contributor

jrfnl commented Mar 24, 2018

@umherirrender PR #1964 should fix this.

gsherwood added a commit that referenced this issue Mar 25, 2018
@gsherwood gsherwood removed this from Ready for Release in PHPCS v3 Development Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants