Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review that existing sniffs will handle PHP 7.4 typed properties correctly #2517

Closed
2 tasks
jrfnl opened this issue May 23, 2019 · 1 comment
Closed
2 tasks

Review that existing sniffs will handle PHP 7.4 typed properties correctly #2517

jrfnl opened this issue May 23, 2019 · 1 comment
Assignees
@gsherwood
Projects
PHPCS v3 Development
Milestone
3.5.0

Comments

@jrfnl
Copy link
Contributor

jrfnl commented May 23, 2019

Follow up ticket after #2413.

Open action points:

  • Adjust property docblock sniffs to allow finding the docblock of typed properties.
  • Check that other sniffs which deal with properties handle typed properties correctly by adding unit tests and if necessary, adjusting the code within the sniff.

FYI: If/when PR #2456 gets merged, addressing action point 1 will be dead easy as it will just be a minor adjustment to one method in one of the new utility classes.
@gsherwood gsherwood added this to Backlog in PHPCS v3 Development via automation May 23, 2019
@gsherwood gsherwood added this to the 3.5.0 milestone May 23, 2019
@gsherwood gsherwood removed this from Backlog in PHPCS v3 Development May 27, 2019
@gsherwood gsherwood added this to Backlog in PHPCS v3 Development via automation May 27, 2019
@gsherwood gsherwood self-assigned this May 27, 2019
gsherwood added a commit that referenced this issue May 27, 2019
@gsherwood
Making sure var sniffs work with types; only Squiz.Commenting.Variabl…
beeb36f 
…eComment needed a change (ref #2517)
@gsherwood
Copy link
Member

I tested all the var sniffs I could find and added some tests. Only 1 needed changing as it was looking backwards for a comment.

PHPCS v3 Development automation moved this from Backlog to Ready for Release May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsherwood gsherwood

Labels
None yet
Projects
PHPCS v3 Development
Ready for Release
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@gsherwood @jrfnl