Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement codeclimate reporter #2813

Closed
andrei-stsiapanau opened this issue Jan 11, 2020 · 4 comments
Closed

Implement codeclimate reporter #2813

andrei-stsiapanau opened this issue Jan 11, 2020 · 4 comments

Comments

@andrei-stsiapanau
Copy link

It is nice to have Codeclimate reporter plugin to be able to integrate codesniffer with gitlab-ci.

@jrfnl
Copy link
Contributor

jrfnl commented Jan 11, 2020

@Stephanoff Could you elaborate a little on what you mean by this ? Maybe add some links too ?

@andrei-stsiapanau
Copy link
Author

There is existing tool called Codeclimate used for the GitLab CI AutoDevOps.
There is an example their report implementation https://github.com/codeclimate/codeclimate-phpcodesniffer
But running Codeclimate on the large project is not an option since common case is use PHPCS installed from composer.
I didn't happy about their approach hardcoding report generator inside their package.

@jrfnl
Copy link
Contributor

jrfnl commented Jan 11, 2020

@Stephanoff Ah, I understand now and I agree it would be better to have a report type for that, but that doesn't necessarily have to be in PHPCS itself and as your PR contains hard-coded sniff names and such which would need regular maintenance and is tied into the composer.json for CodeClimate, I'm wondering if it wouldn't be better to pull your report to the CodeClimate repo ?

An external repo can use their own report by name. See #1942 and #1948 for how to implement this.

@andrei-stsiapanau
Copy link
Author

Great, thank you!
Will do it as a separate reporter. I am not sure about integrating this reporter into CodeClimate, will ask them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants