PHP 8.1 support

[kukulich]

Issue to track what needs to be done:

• Support of enum keyword PHP 8.1: Added support for enum keyword #3478
• enum support to sniffs PHP 8.1: Added enum support to sniffs #3482
• New token T_ENUM_CASE PHP 8.1: Added T_ENUM_CASE #3483
• Support of readonly keyword PHP 8.1: Added support for readonly keyword #3480
• never buildin type PHP 8.1: Support of never type #3582
• Intersection types - new token T_TYPE_INTERSECTION and update File::getMethodParameters(), File::getMethodProperties() and File::getMemberProperties() PHP 8.1: Support of intersection types #3581
• Explicit octal notation Support for PHP 8.1 Explicit Octal Notation in the Tokenizer #3481
• Final constants - reported in PSR12.Properties.ConstantVisibility false positive when using public final const syntax PSR12.Properties.ConstantVisibility false positive when using public final const syntax #3526, fixed in PHP 8.1 | PSR12/ConstantVisibility: allow for class constants to be final PHP 8.1 | PSR12/ConstantVisibility: allow for class constants to be final #3527. A cursory review of existing sniffs showed no other obvious sniffs which would need adujsting.

[jrfnl]

Proposal:

For intersection types, I'd like to propose to re-tokenize to a new PHPCS native T_TYPE_INTERSECTION to prevent sniffs looking for T_BITWISE_AND from getting confused and starting to try and handle the token.

This is in-line with the changes made for PHP 8.0 union types (see #3032 and #3302).

Note: the File::getMethodParameters(), File::getMethodProperties() and File::getMemberProperties() methods will also need adjusting.

---

Also note that the File::getMemberProperties() method also still needs adjusting for the readonly keyword.

[jrfnl]

Check sniffs that use Tokens::$ooScopeTokens

For all Tokens arrays being updated with new tokens:

• Check every single PHPCS native sniff using them for either handling the new syntax correctly or bowing out.
• No matter what the decision: add a couple of tests to each of these sniffs to guard against the sniff throwing false positives for the new syntax/fixing things incorrectly etc.
• Even when not using the Tokens arrays, see if sniffs looking for "similar" tokens need to add support for the new syntaxes.
  Think for example: sniffs which looks at type declarations in a function declaration will now also need to handle intersection types and never. In most cases, those sniffs will use the File::getMethodParameters() and File::getMethodProperties(), so instead of doing a token search, do a search for usage of these methods and review each sniff using them.

[MarkBaker]

Addition to the list:

• Support for first class callable syntax

e.g.

$result = array_map(trim(...), $array);

At the moment, this tokenises to T_ELLIPSIS; but it might be a good idea to change that to a new token (T_FIRST_CLASS_CALLABLE) which will then make the usage explicit

[jrfnl]

At the moment, this tokenises to T_ELLIPSIS; but it might be a good idea to change that to a new token (T_FIRST_CLASS_CALLABLE) which will then make the usage explicit

For the purpose of writing sniffs, I think it is completely unnecessary to retokenize that. Use as a first class callable is straightforward to detect (is the next non-empty token a close parenthesis ?).

Retokenizing to a PHPCS native token constant is generally only done when it would need a lot of logic within a sniff to determine whether the token is the target token, or when not retokenizing would lead to lots of false positives in pre-existing sniffs.

Neither applies.

[jrfnl]

To add to the list:

• Final constants - reported in PSR12.Properties.ConstantVisibility false positive when using public final const syntax #3526, fixed in PHP 8.1 | PSR12/ConstantVisibility: allow for class constants to be final #3527. A cursory review of existing sniffs showed no other obvious sniffs which would need adujsting.

[nunoperalta]

I was about to report the same as #557

enum being detected as GOTO:

enum Suit: string {
	case Hearts = 'H';
	case Diamonds = 'D';
	case Clubs = 'C';
	case Spades = 'S';
}

Use of the GOTO language construct is discouragedPHPCS(Generic.PHP.DiscourageGoto.Found)

[jrfnl]

@nunoperalta There is already a PR open to fix that: #3534

[nunoperalta]

@jrfnl nice one! Any idea when it will be merged? I see it's been there for 15 days. Thank you very much.

[jrfnl]

nice one! Any idea when it will be merged?

@nunoperalta When the maintainers have time to review.

[acidjazz]

👀 @jrfnl @gsherwood @michalbundyra @gmponos 👀

[acidjazz]

@gsherwood @jrfnl @kukulich loving and using Enums in all of my current projects

is it possible at all to just get #3482 merged and release that?

[kukulich]

Everything is solved now in master.

[mreduar]

Thank you!! When will the release be made?