Ability to set array values using phpcs:set #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsherwood Any chance to have it merged into 3.3.0 release? I need this to test my custom sniff with array properties. Or maybe there is another way to do it? Thanks! |
|
Because of hotfix #2004 probably this is not gonna work to set empty value. Maybe we should allow just: // phpcs:set Squiz.PHP.SniffName property[](so no value provided) and it will mean to set empty value ( |
Property name should be with [] and values must be comma separated. If we want provide also array keys we need to separate them with =>. So the format is the same as the one possible format in ruleset, i.e.: // phpcs:set Squiz.PHP.SniffName property[] key=>value,key2=>value2
michalbundyra
force-pushed
the
feature/phpcs-set-array-values
branch
from
320e951
to
7575ad9
Compare
|
Rebased with base #2004. // phpcs:set Squiz.PHP.SniffName property[]and // phpcs:set Squiz.PHP.SniffName property(so there is no value at all, it means to set empty value). |
gsherwood
moved this from Selected for Development (v3)
to In Progress
in PHPCS v3 Development
|
Thanks a lot for this change |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property name should be with
[]and values must be comma separated.If we want provide also array keys we need to separate them with
=>.So the format is the same as the one possible format in ruleset, i.e.:
// phpcs:set Squiz.PHP.SniffName property[] key=>value,key2=>value2