Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests: report on number of sniff test case files tested #2289

Merged
merged 1 commit into from Dec 10, 2018
Merged

Unit Tests: report on number of sniff test case files tested #2289

merged 1 commit into from Dec 10, 2018

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 4, 2018

This commit adds an additional line below a unit test run, listing how many sniff test case files were examined. This information can be used as input to check and debug unit test runs.

@jrfnl
Unit Tests: report on number of sniff test case files tested
91352da 
This commit adds an additional line below a unit test run, listing how many sniff test case files were examined. This information can be used as input to check and debug unit test runs.
@gsherwood gsherwood added this to the 3.4.0 milestone Dec 6, 2018
@gsherwood gsherwood added this to Backlog in PHPCS v3 Development via automation Dec 6, 2018
@gsherwood gsherwood merged commit 91352da into squizlabs:master Dec 10, 2018
PHPCS v3 Development automation moved this from Backlog to Ready for Release Dec 10, 2018
gsherwood added a commit that referenced this pull request Dec 10, 2018
@gsherwood
Change the output format a bit (ref #2289)
33c5169
@gsherwood
Copy link
Member

Good idea, although the extra lines were getting to me, so I just compressed it to one line. Looks like this now:

$ phpunit
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

...............................................................  63 / 366 ( 17%)
............................................................... 126 / 366 ( 34%)
.......................................S....................... 189 / 366 ( 51%)
............................................................... 252 / 366 ( 68%)
............................................................... 315 / 366 ( 86%)
.........................................SS........

371 sniff test files generated 643 unique error codes; 374 were fixable (58.16%)

Time: 16.98 seconds, Memory: 36.00MB

OK, but incomplete, skipped, or risky tests!

@jrfnl jrfnl deleted the feature/report-number-of-tested-case-files branch December 10, 2018 00:53
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 10, 2018

LGTM 👍

@jrfnl jrfnl mentioned this pull request Jan 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PHPCS v3 Development
Ready for Release
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrfnl @gsherwood