PSR12.Squiz.OperatorSpacing false positive for default values of arrow functions #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/squiz-operatorspacing-arrow-function-defaults-plus-minus
branch
from
285fff5
to
49de503
Compare
|
Rebased for merge conflicts |
The plus/minus in a default value of a function parameter declaration is ignored for normal functions and closures, but wasn't ignored yet for arrow functions. Fixed now. Includes unit test + test for the same for closures, which so far wasn't tested yet. This also, by extension, fixes the same issue in the `PSR12.Operators.OperatorSpacing` sniff.
gsherwood
changed the title
|
Thanks a lot for this fix. It has been merged in, but I was doing a rebase and the commit hashes got changed over. |
jrfnl
deleted the
feature/squiz-operatorspacing-arrow-function-defaults-plus-minus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plus/minus in a default value of a function parameter declaration is ignored for normal functions and closures, but wasn't ignored yet for arrow functions.
Fixed now.
Includes unit test + test for the same for closures, which so far wasn't tested yet.
This also, by extension, fixes the same issue in the
PSR12.Operators.OperatorSpacingsniff.