PHP 8.1: fix deprecation notice #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Util\Standards::getInstalledStandardPath()` method returns either a string or `null`, however the `strpos()` method which is used in both the `Util\Common::isPharFile()` method, as well as in the follow-on condition, only accepts a `string` as `$haystack`. As of PHP 8.1, this will generate a deprecation notice `strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated`. Discovered while testing an external standard against PHPCS `master` on PHP 8.1. Fixed now.
This was referenced Feb 28, 2021
|
Nice find, thanks |
|
Thanks for merging this! Retriggering the build via which I found it now to see if it goes 🟢 |
|
Nope, still failing, now on a similar, but different error. Follow-up PR upcoming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Util\Standards::getInstalledStandardPath()method returns either a string ornull, however thestrpos()method which is used in both theUtil\Common::isPharFile()method, as well as in the follow-on condition, only accepts astringas$haystack.As of PHP 8.1, this will generate a deprecation notice
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated.Discovered while testing an external standard against PHPCS
masteron PHP 8.1.Fixed now.