Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File::getMemberProperties(): minor tweaks after readonly merge #3515

Merged
merged 1 commit into from
May 16, 2022
Merged

File::getMemberProperties(): minor tweaks after readonly merge #3515

merged 1 commit into from
May 16, 2022

Commits on Apr 23, 2022

  1. File::getMemberProperties(): minor tweaks after readonly merge 

    Follow up on 3480

I realized after the merge that I had not published a few follow up comments. Addressing those here.

* The new `is_readonly` key still needed to be added to the documentation for the `File::getMemberProperties()` method.
* For consistency in how the method is tested, adding the `is_readonly` property to all other test expectations, which makes the `testPHP81NotReadonly` test case redundant.
* Adding two additional test cases. In particular I wanted to verify (and safeguard) that the retokenization of the `?` to `T_NULLABLE` after a `readonly` keyword would not be broken (which it partially was, but that has now been fixed in 3513).
    @jrfnl
    jrfnl committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    9d4c6d1 View commit details
    Browse the repository at this point in the history