Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 | Tokenizer, File, sniffs: account for new true type #3662

Closed
wants to merge 6 commits into from
Closed

PHP 8.2 | Tokenizer, File, sniffs: account for new true type #3662

wants to merge 6 commits into from

Commits on Mar 2, 2023

  1. PHP 8.2 | Tokenizer/PHP: allow for true in union types 

    Previously, `false` and `null` were already allowed in union types. As of PHP 8.2, `true` has been added to the supported types in PHP and can also be used in union types.
Also see: https://3v4l.org/ZpfID

This commit adjusts the Tokenizer to correctly retokenize the `T_BITWISE_OR` character to `T_UNION_TYPE` when `true` is included in a union type.

Includes unit tests.

Refs:
* https://wiki.php.net/rfc/true-type
    @jrfnl
    jrfnl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5cfbe6c View commit details
    Browse the repository at this point in the history

  2. PHP 8.2 | File::getMethodProperties(): allow for true in types 

    As of PHP 8.2, `true`, `false` and `null` will be allowed as stand-alone types. `true` can now also be used in union types (was already allowed for `false` and `null`).
The `true` and the `false` types are allowed to be nullable, the `null` type is not (but that's not the concern of this method).
Also see: https://3v4l.org/ZpfID

This commit adjusts the `File::getMethodProperties()` method to take `true` into account. `false` and `null` were already handled due to these previously already being allowed in union types.

Includes unit tests.

Refs:
* https://wiki.php.net/rfc/null-false-standalone-types
* https://wiki.php.net/rfc/true-type
    @jrfnl
    jrfnl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    6cbd3a4 View commit details
    Browse the repository at this point in the history

  3. PHP 8.2 | File::getMethodParameters(): allow for true in types 

    As of PHP 8.2, `true`, `false` and `null` will be allowed as stand-alone types. `true` can now also be used in union types (was already allowed for `false` and `null`).
The `true` and the `false` types are allowed to be nullable, the `null` type is not (but that's not the concern of this method).
Also see: https://3v4l.org/ZpfID

This commit adjusts the `File::getMethodParameters()` method to take `true` into account. `false` and `null` were already handled due to these previously already being allowed in union types.

Includes unit tests.

Refs:
* https://wiki.php.net/rfc/null-false-standalone-types
* https://wiki.php.net/rfc/true-type
    @jrfnl
    jrfnl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    571f930 View commit details
    Browse the repository at this point in the history

  4. PHP 8.2 | File::getMemberProperties(): allow for true in types 

    As of PHP 8.2, `true`, `false` and `null` will be allowed as stand-alone types. `true` can now also be used in union types (was already allowed for `false` and `null`).
The `true` and the `false` types are allowed to be nullable, the `null` type is not (but that's not the concern of this method).
Also see: https://3v4l.org/ZpfID

This commit adjusts the `File::getMemberProperties()` method to take `true` into account. `false` and `null` were already handled due to these previously already being allowed in union types.

Includes unit tests.

Includes minor touch up of some pre-existing tests.

Refs:
* https://wiki.php.net/rfc/null-false-standalone-types
* https://wiki.php.net/rfc/true-type
    @jrfnl
    jrfnl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    7fcafe4 View commit details
    Browse the repository at this point in the history

  5. PHP 8.2 | Generic/LowerCaseType: allow for stand-alone true/false/null 

    As of PHP 8.2, `true`, `false` and `null` will be allowed as stand-alone types.
The `true` and the `false` types are allowed to be nullable, the `null` type is not (but that's not the concern of the sniff).
Also see: https://3v4l.org/ZpfID

This commit adjusts the sniff to take `true` into account. `false` and `null` were already handled due to these previously already being allowed in union types.

Includes unit tests.

Refs:
* https://wiki.php.net/rfc/null-false-standalone-types
* https://wiki.php.net/rfc/true-type
    @jrfnl
    jrfnl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    18c2eee View commit details
    Browse the repository at this point in the history

  6. PHP 8.2 | PSR12/NullableTypeDeclaration: allow for nullable true/false 

    As of PHP 8.2, `true`, `false` and `null` will be allowed as stand-alone types.
The `true` and the `false` types are allowed to be nullable, the `null` type is not (but that's not the concern of the sniff).
Also see: https://3v4l.org/ZpfID

This adjusts the sniff to take these new types into account.

Includes unit tests.

Refs:
* https://wiki.php.net/rfc/null-false-standalone-types
* https://wiki.php.net/rfc/true-type
    @jrfnl
    jrfnl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3e3620f View commit details
    Browse the repository at this point in the history