Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential "Uninitialized string offset 1" in octal notation backfill #3722

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 5, 2022

... in the backfill for the PHP 8.1 explicit octal notation.

Includes unit tests.

... in the backfill for the PHP 8.1 explicit octal notation.

Includes unit tests.
@jrfnl jrfnl force-pushed the feature/tokenizer-php-bugfix-in-explicit-octal-backfill branch from cdfa79f to 38178f4 Compare March 2, 2023 04:06
@gsherwood gsherwood changed the title Tokenizer/PHP: bug fix for potential "Uninitialized string offset 1" Potential "Uninitialized string offset 1" in octal notation backfill May 4, 2023
@gsherwood gsherwood added this to Idea Bank in PHPCS v3 Development via automation May 4, 2023
@gsherwood gsherwood added this to the 3.8.0 milestone May 4, 2023
gsherwood added a commit that referenced this pull request May 4, 2023
@gsherwood gsherwood merged commit 38178f4 into squizlabs:master May 4, 2023
PHPCS v3 Development automation moved this from Idea Bank to Ready for Release May 4, 2023
@gsherwood
Copy link
Member

Thanks :)

@jrfnl jrfnl deleted the feature/tokenizer-php-bugfix-in-explicit-octal-backfill branch May 4, 2023 06:04
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2023

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PHPCS v3 Development
Ready for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants