fix: Attributes id injection in first tag.

srackham · Feb 12, 2018 · 862a463 · 862a463
1 parent 6b175e8
commit 862a463
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/rimu/utils.ts b/src/rimu/utils.ts
@@ -154,7 +154,7 @@ export namespace BlockAttributes {
     }
     if (id) {
       id = id.toLowerCase()
-      let has_id = /id=".*?"/i.test(tag)
+      let has_id = /^<[^<]*id=".*?"/i.test(tag)
       if (has_id || ids.indexOf(id) > -1) {
         Options.errorCallback(`duplicate 'id' attribute: ${id}`)
       }

diff --git a/test/rimu-tests.json b/test/rimu-tests.json
@@ -1778,6 +1778,15 @@
       "reset": true
     }
   },
+  {
+    "description": "html id injection in first tag",
+    "input": ".#foo\n<p></p><p id=\"bar\"></p>",
+    "expectedOutput": "<p id=\"foo\"></p><p id=\"bar\"></p>",
+    "expectedCallback": "",
+    "options": {
+      "reset": true
+    }
+  },
   {
     "description": "html attributes skipped by safeMode=2",
     "input": ".[style=\"color: red;\"]\nError message",