Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error range to results #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mitar
Copy link

@mitar mitar commented Apr 15, 2022

I wanted to add error bars to results for cases when parties have not responded to all questions. But it turns out only one current party has not (Povezimo Slovenijo), so this is pretty limited in usefulness. Still, I am making a PR because it maybe will be useful at some point.

Currently it just shows a range next to the percentage, but it does not change how the progress bar is visualized. Maybe somebody else wants to tackle that.

Probably I have to update some tests as well, because getResultsByScore is not returning more data.

I have not committed build so that it is easier to merge this PR. After merging it should be rebuild.

TODO:

  • Update tests.
  • Add some message next to results explaining what this range is, if any such range is shown (that the party didn't respond to everything, so there is a possible range of the match).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant