Add GITBASE_READONLY env var #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rporres
suggested changes
Jul 4, 2018
| @@ -142,6 +142,8 @@ spec: | |||
| value: "{{ .Values.gitbaseServer.repositoriesDir }}" | |||
| - name: GITBASE_UNSTABLE_SQUASH_ENABLE | |||
| value: "{{ .Values.gitbaseServer.squashEnable }}" | |||
| - name: GITBASE_READONLY | |||
There was a problem hiding this comment.
Please enclose this in a conditional to avoid adding an empty env variable if gitbaseServer.readonly is empty
My bad for not having enforced this in your previous PR around GITBASE_UNSTABLE_SQUASH_ENABLE
gitbase-playground/values.yaml
Outdated
| @@ -77,6 +77,7 @@ gitbaseServer: | |||
| size: 10Gi | |||
| logLevel: debug | |||
| squashEnable: "" | |||
| readonly: "" | |||
There was a problem hiding this comment.
Comment this out, just signaling it is a possibility to set it. It does not make sense to set env variables to empty values
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
carlosms
force-pushed
the
gitbase-readonly
branch
from
c46e585
to
a08de30
Compare
|
I've made the requested changes, rebasing to have 1 commit only. |
rporres
approved these changes
Jul 5, 2018
|
Thx for fixing the squash variable too 😍 |
smacker
reviewed
Jul 5, 2018
| @@ -140,8 +140,14 @@ spec: | |||
| value: "{{ .Values.gitbaseServer.logLevel }}" | |||
| - name: GITBASE_REPOS | |||
| value: "{{ .Values.gitbaseServer.repositoriesDir }}" | |||
| {{- if ..Values.gitbaseServer.squashEnable }} | |||
There was a problem hiding this comment.
Does it work? Here is 2 dots...
There was a problem hiding this comment.
It shouldn't... Well spotted! 😅
@carlosms Can you please send a fix?
|
Good catch. Fix here: #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #58.