Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-coverage always succeeds #56

Open
vmarkovtsev opened this issue Feb 13, 2018 · 3 comments
Open

make test-coverage always succeeds #56

vmarkovtsev opened this issue Feb 13, 2018 · 3 comments
Labels

Comments

@vmarkovtsev
Copy link
Collaborator

vmarkovtsev commented Feb 13, 2018

make test-coverage never errors, even if the tests failed to build. Expected behavior: in case of any error, abort make and set the exit code, as all the normal build targets do.

This is especially funny when you realize that the test suite never actually ran after a few weeks.

@smola smola added the bug label May 4, 2018
@smola
Copy link
Contributor

smola commented May 4, 2018

@vmarkovtsev Is this still happening? Could you share more info about the project where this is happening? Do you have a link to an example build on Travis CI exhibiting this problem?

@vmarkovtsev
Copy link
Collaborator Author

I will be able to recover on Monday.

@vmarkovtsev
Copy link
Collaborator Author

Link: https://ci.appveyor.com/project/mcuadros/client-go/build/5#L61

I don't see it in the recent builds, so maybe the cause of that particular error was fixed. I am not sure that the ignoring behavior is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants