Windows support

[vmarkovtsev]

E.g. hardcoded SHELL to /bin/bash and other things I have not checked yet.

Minimal requirement to consider this fixed: no errors in bblfsh/client-go.

[smola]

In the end, /bin/bash et al are staying. We'll support Windows, but a working version of GNU make, bash, grep, date, git, cat, rm and some other basic tools are required. I have tested this with msys2+MinGW.

test-coverage requires curl. Docker stuff requires a docker client (probably set up to use a Linux docker host).

[vmarkovtsev]

@smola How will it work if /bin/bash is an illegal path on Windows?..

[vmarkovtsev]

BTW now I remember that this is related to #56

[smola]

@vmarkovtsev Because we run this with mingw32-make, which uses path translation. I think /bin/bash becomes %PATH TO MINGW ROOT%/bin/bash. Honestly, I still don't get some of the details, since the solution mixes some binaries from msys2 and mingw 64bit... but I got a branch working with rovers on Appveyor.

[vmarkovtsev]

@smola New shocking details of CI running on Windows. This is what i see in the logs:

make[1]: Entering directory 'C:/Users/User/go/src/gopkg.in/bblfsh/client-go.v2'
process_begin: CreateProcess(NULL, pwd, ...) failed.
make[1]: makefile:22: pipe: No error
process_begin: CreateProcess(NULL, pwd, ...) failed.
make[1]: makefile:24: pipe: No such file or directory
git clone --quiet --depth 1 https://github.com/src-d/ci.git /.ci;

And this is what I see in Explorer:

That is, some terrible path issues.

[smola]

@vmarkovtsev Could you post here your make --version?

Try with mingw32-make (part of mingw distribution) if you aren't already.

Also, define your CI_PATH just as .ci in your Makefile (not $(shell pwd)/.ci or $PWD/.ci or anything like that).

[vmarkovtsev]

@smola https://github.com/src-d/hercules/blob/master/appveyor.yml#L11

[vmarkovtsev]

@smola Looks like a PR to https://github.com/bblfsh/client-go/blob/master/Makefile#L21

[smola]

@vmarkovtsev Updated my PR: https://github.com/bblfsh/client-go/pull/56

[smola]

@vmarkovtsev For hercules, just do not install make, use mingw32-make which is available with set PATH=C:\mingw-w64\x86_64-7.2.0-posix-seh-rt_v5-rev1\mingw64\bin;C:\msys64\usr\bin;%PATH%

[vmarkovtsev]

OK, will try

[smola]

Closing, since basic support is already there.
@vmarkovtsev Please, open a separate issue if there is any further problem, thanks!