Add CI, docs and fix integration tests #15

dpordomingo · 2018-05-08T12:15:20Z

required by #1
address #5

I ran it in my own Travis, in a private PR dpordomingo#8 and here is the result:

on pull_request → PR review stage 1
on merge agains master → integration review stage 1
on tag → release docker images and GH assets stage 1+2+3

Tag with assets to validate (darwin and linux) → dpordomingo/gitbase-playground#v0.0.1

Docker image to validate → hub.docker.com/dpordomingo/gitbase-playground

Assumptions for the first iteration

it's used dpordomingo accounts for DockerHub and Travis till there are company ones,
it's used dpordomingo/ci because there are PR in src-d/ci that has not been merged yet,
(Fix version variable ci#67 and Let the validation to check untracked files ci#62)
there is no frontend yet, but the make rules are copied from code-annotation (it might change in the next iteration),

Documentation

It was added:

README.md
docs/
- CONTRIBUTING.md
- quickstart.md guideline to run the playground with its dependencies
CODE_OF_CONDUCT.md and DCO

CI in Travis:

There are three stages (each one of them runs if the prev one succeeded):
- validate and build to ensure the QA, that runs on pull_request, tag, master and staging,
- release to github to publish build assets (linux/darwin) to GH release on every tag,
- push to dockerhub to publish the docker image (+ :latest) to DockerHub on every tag,
Travis conf should use as much src-d/ci::v1 api as possible,
make validate-commit checks that:
- there is no fixable/lintable code,
- no vendors were missing, and
- ./server/assets/asset.go proxy was not ruined,

Integration tests

They where added by #10, but as pointed by #10 (comment) they cannot be run in Travis yet.

It was also done:

it seems that people call them *_integration_test.go,
use make back-test-integration to run them locally (it is needed an instance of bblfsh and gitbase)

dpordomingo · 2018-05-08T12:28:30Z

idk why DCObot says that last commit 1c89a64 is not signed-off :S

bzz · 2018-05-08T13:39:54Z

👏 for detailed description!!

I assume that all commits with the message staring with WORKAROUND are not proposed to be merged, is that correct?

It's totally fine to have a branch with those and even a PR with [DO NOT MERGE] testing CI but it would make review much easier not to have them here.

Meanwhile I assume only master...dpordomingo:478c14d needs to be reviewed

dpordomingo · 2018-05-08T13:50:22Z

Depending on the missing services or dependencies, they would be needed. For example the one with the ci if the PR is not merged (src-d/ci#67 and src-d/ci#62) .
About the ones using Dockerhub, Travis or Codecov, I'll review them again and remove if the those config are already provided; otherwise they would be needed too.

The benefit on having separated commits for them, is that now we can rollback the separately to restore the expected behavior. And also that the commits being reviewed does not include «hack things»

bzz · 2018-05-08T13:54:48Z

Let's just let CI fail, if something is missing and fix that gradually and visibly, in subsequent PRs if needed, rather then use personal forks.

For me, it's ok to keep here only the fork of src-d/ci for now, as this seems to be merged soon.

TravisCI has been enabled
TravisCI: add GITHUB_TOKEN
Get new Codecov Token for https://codecov.io/gh/src-d/gitbase-playground (sent to @dpordomingo )
new repository on DockerHub

Any other action items to fix?

carlosms

👍 Left a few minor comments.

carlosms · 2018-05-08T14:28:30Z

README.md


-Launch [bblfshd](https://github.com/bblfsh/bblfshd) and install the drivers. More info in the [bblfshd documentation](https://doc.bblf.sh/user/getting-started.html).
+Web application powered by [gitbase](https://github.com/src-d/gitbase), were you can query git repositories with a MySQL.


I find this sentence a bit confusing. What about something like:
Web application to query git repositories using SQL. Powered by gitbase.

great! thanks!

carlosms · 2018-05-08T14:31:22Z

README.md


-Built binary:
+Read [more about how to run bblfsh and gitbase dependencies](docs/quickstart.md).


In my opinion we could include the contents here in the main readme. These are mandatory dependencies, without it you can't do anything. And the quickstart doc is not so big.

I don't think the same.
Our documentation guidelines suggest to consider the README.md an "overview of the project", and suggest adding only "basic installation instructions. If the instructions are long they should be part of a different document linked from this one."
Our guides also consider the README.md as an "index for all other documentation" so it seems that using other docs for more details is something welcomed.

And I find another reason to do so: The instalation of the dependencies is not something "core" in the project, something so relevant that should be moved to the main README.md; on the other hand, if we move them to a separate doc, it can be considered as a minor thing more easily (edited, deleted...)

Thanks for explaining the reasoning. I still find it confusing that the readme includes "incomplete" instructions. What is GITBASE_CONTAINER referring to a few lines below? As the guidelines say, maybe this should all be moved to one place only, the quickstart guide?

Anyway it's just a matter of opinion, up to you.

Thanks for spotting the GITBASE_CONTAINER leftover (it came from the quickstart.md).
I fixed it a87c446 to be consistent with the whole docker command: "link with a gitbase container, and use it as a connection addres".

Many thanks for taking your time in reviewing so deeply the README.md 👍; I appreciate it a lot, and I'm sure that @campoy will do it too once this project gets more mature.

carlosms · 2018-05-08T14:32:25Z

cmd/gitbase-playground/main.go

@@ -27,7 +27,7 @@ type appConfig struct {
 	Host      string `envconfig:"HOST" default:"0.0.0.0"`
 	Port      int    `envconfig:"PORT" default:"8080"`
 	ServerURL string `envconfig:"SERVER_URL"`
-	DBConn    string `envconfig:"DB_CONNECTION" default:"root@tcp(localhost:3306)/none?maxAllowedPacket=4194304"`
+	DBConn    string `envconfig:"DB_CONNECTION" default:"gitbase@tcp(localhost:3306)/none?maxAllowedPacket=4194304"`


Is this working out of the box? do you need any extra steps to configure gitbase to accept this user?

that's the gitbase default https://github.com/src-d/gitbase/blob/master/Dockerfile#L18 and it worked out of the box with that username (with root failed)

👍 I was running it from the source code, where root is the default.

Indeed, this is very confusing.

It would be nice to add a small notice to "Running from Source" section of contributing.md about this - that in case of running gitbase from source, this ENV bar becomes a must.

That would save some frustration for people who read the docs.

I was thinking in purposing the refactor of the DB_CONNECTION parameter to be:

DB_USER default:"gitbase" DB_PASSWORD DB_HOST default:"localhost" DB_PORT default:"3306"

That way it would be easy to documment each one, and to modify only some parts of the connection string.

But I thought it would be better to handle this suggestion in a separated issue.
@bzz Would you agree on discussing it in the next iteration? If you do, I'll open an issue with your suggestions and my ideas.

carlosms · 2018-05-08T14:34:37Z

docs/CONTRIBUTING.md

+```
+
+
+## Run from sources


Titlecase: Run from Sources

carlosms · 2018-05-08T14:39:21Z

docs/CONTRIBUTING.md

+
+It will test that `gitbase` and `bblfshd` are running and available for the playground.
+
+It is needed to serve under `gitbase` a copy of the `https://github.com/src-d/gitbase-playground` repository


"serve under gitbase" sound a bit confusing to me. This section would be much more clear if you copied the instructions from the quickstart doc.

The quickstart has a different purpose; it's about dependencies, but this one is about the integration tests requirements.

Would you prefer @carlosms this other paragraph? https://github.com/src-d/gitbase-playground/pull/15/files#diff-8595297407c24b9ccb87b2a698cca9c2R80

To let the tests succeed, it will be also needed to configure the running gitbase to serve a copy of the https://github.com/src-d/gitbase-playground repository.

Do you have any other suggestion ? 😉

carlosms · 2018-05-08T14:40:03Z

docs/quickstart.md

@@ -0,0 +1,70 @@
+# Quickstart
+
+## bblfsh and gitbase dependencies


Title case: Dependencies

carlosms · 2018-05-08T14:41:11Z

docs/quickstart.md

+You have more information on the playground architecture and development guides in the [CONTRIBUTING.md#development](CONTRIBUTING.md#development).
+
+
+## run a query


Title case: Run a Query

dpordomingo · 2018-05-08T15:19:58Z

Many thanks, @carlosms for your suggestions!
I addressed some of your requirements at 58fa9f2 and added some questions to clarify some other doubts I found.

dpordomingo · 2018-05-08T15:33:52Z

@bzz I removed the WORKAROUND commits as agreed and CI passed!!
Thanks for enabling all needed accounts!

The missing ones are:

usage of dpordomingo/ci:v1 → it will be reverted/dropped once Fix version variable ci#67 and Let the validation to check untracked files ci#62 have been merged,
usage of dpordomingo/gitbase image → there is no released image yet but it will be pushed on next gitbase release

carlosms · 2018-05-08T15:37:41Z

docs/CONTRIBUTING.md

+- serving the app for development purposes, [building and running it from sources](#run-from-sources)
+
+
+# Configuration


Maybe this section should be moved to the quickstart guide? These env vars are also relevant to people interested in running the released binaries or docker.

I'm not pretty sure, but I have no strong opinion at all about it because I see the benefit of both approaches.

If you agree, we can take care of the docs in a next iteration considering this, and other things like docsrv, index with docs, running examples, hot reloading...
But if you prefer to move now the Configuration section from the CONTRIBUTING.md to the quickstart.md just say so and I'll do it.

In the meantime, I added 98fc7ef#diff-018e220b50f876168d6d1d4dbf52ce84R65 in the quickstart.md a link to this section, so as you said "people interested in running the released binaries or docker" will be benefited from the crossing links.

carlosms

🎉

carlosms · 2018-05-08T15:39:48Z

README.md


-Use `GITBASEPG_ENV=dev` for extra logs information.
+## Run the playground


carlosms · 2018-05-08T15:40:00Z

README.md

-Built binary:
+Read [more about how to run bblfsh and gitbase dependencies](docs/quickstart.md).
+
+### Run with docker


carlosms · 2018-05-08T15:40:46Z

README.md

 ```

-### Run the Tests
+
+### Run binary


smacker

found few small issues and few questions

smacker · 2018-05-08T16:24:02Z

Makefile

+	$(GOVET) $@
+
+back-start:
+	GITBASEPG_ENV=dev go run cmd/gitbase-playground/main.go


I thought we agreed to be prod by default for our applications, no?

You're right, but back-start target is meant for dev purposes only.
Would you prefer it to be launched with prod conf?

If it's only for development I would prefer to run it with proper dev environment.

But looks like it's not only dev command. In serve rule you call back-start. And make serve is a recommended way to run our applications (at least 2 others of them) if the one doesn't want to use docker.

If I'm not mistaken in code annotation you suggested to run apps in prod mode for such case.

Yes, you're right @smacker : I purposed (and purpose) to set the defaults to prod settings when it is being used for final users. The rationale in behind would be

final users should be able to run the app with as less configuration effort as possible

Since this tool was purposed to be a final user app, the README.md only recommends to run the app with docker or through a released binary

Because of that reason: "to make the tool easy to run for the final user", with as less dependencies as possible (only the really needed), the make serve recommendation was moved to the CONTRIBUTING.md#development section.

If all of you think that we should recommend to run the tool that other way (with go, GOPATH, yarn...) then I'd move it to the README.md and remove the dev conf in the rule.

I like using make only for dev 👍

smacker · 2018-05-08T16:25:07Z

Makefile

+
+# this::build -> Makefile.main::build -> Makefile.main::$(COMMANDS)
+build: front-build back-build
+	@echo


could you please explain why do we need echo here?

because it is needed to run this target before the Makefile.main::build one.
If you drop the recipe inside the target, it is run following the declaration order, what would be wrong in this case.

wah. could you please add a comment about it. I see

this::build -> Makefile.main::build -> Makefile.main::$(COMMANDS)

comment, but I didn't get it. Your explanation is much better.

smacker · 2018-05-08T16:25:46Z

Makefile

+	no-changes-in-commit
+
+exit:
+	exit 0;


where do you use it?

Here: https://github.com/src-d/gitbase-playground/pull/15/files/98fc7ef6f847919a9611e5dfd90932885bc898b4#diff-b67911656ef5d18c4ae36cb6741b7965R33

Because the receipes from Makefile.main::dependencies must not be called

I see. Could you please also add a comment. Makefiles are tricky and we don't work with them often, so I would really appreciate documentation for such non-standard cases.

I'll do so.
Makefile → 💥

smacker · 2018-05-08T16:26:23Z

Makefile

+GOVET := go vet
+BINDATA := go-bindata
+DIFF := diff
+GITADD := git add -A


where do you use it?

leftover; good catch

smacker · 2018-05-08T16:29:35Z

docs/CONTRIBUTING.md

+
+There are two main different ways to run the app:
+
+- using released artifacts, as [listed in the README.md#](../README.md#run-the-playground)


listed in the README.md# -> listed in the README.md

smacker · 2018-05-08T16:31:13Z

docs/quickstart.md

+    --publish 9432:9432
+    --volume /var/lib/bblfshd:/var/lib/bblfshd
+    --name ${BBLFSHD_CONTAINER}
+    ${BBLFSHD_IMAGE};


why some commands end with ; and others not?

because you looked deeper than I did ;)
Fixed; thanks!!!

smacker · 2018-05-08T16:32:56Z

server/assets/asset.go.bak

@@ -0,0 +1,40 @@
+// satisfies go-bindata interface


bak file in the repository looks weird...

I'm open to suggestions ;)
The point is that I think we should ensure we do not destroy this file... but how to do it...
ideas? 💃

For this PR it's maybe alright. But I would like to re-think how we work with assets. Maybe we can find better solution.

☝️ that's a great idea. I opened an issue #24 to avoid losing your valuable suggestion.

smacker · 2018-05-08T16:37:43Z

server/service/common.go

@@ -6,4 +6,5 @@ import "database/sql"
 type SQLDB interface {


as I understand we need this interface only for testing purposes.
any particular reason to mock it on this level instead of creating mocked sql.DB?

discussed offline:

we call .Close() on db so just &sql.DB{} wouldn't work

bringing any mocking dependency is out of scope for now

though @dpordomingo is unhappy with this interface too :)

dpordomingo · 2018-05-08T17:45:32Z

Thanks for your detailed review @smacker
Suggestions addressed, and questions answered.

bzz

Overall looks great, wondering if we should merge as is, or change gitbase image name right now accounting for a src-d/gitbase#262 soon to be foxed

bzz · 2018-05-09T06:33:59Z

docs/quickstart.md

+```bash
+$ GITBASE_CONTAINER=gitbase
+$ PLAYGROUND_CONTAINER=gitbasePlayground
+$ PLAYGROUND_IMAGE=src-d/gitbase-playground:latest


In all 3 quickstart examples, what is the value having user to read and copypaste named ENV vars?

It's 9 extra LoC in docs and quickstart usually is shorter the better.

For me using "variables" is more clear, because it exposes what things are in common between different steps, and the meaning in behind some names.
But if you prefer to provide only a "run this command, and go", instead of a kind of "tutorial", just confirm it, and I'll do the changes 🤝

Cool! Yes, I belive "run this command, and go" would fit best for quickstart.

Ant thank you for being receptive and open-minded about such feedback! 💪

thanks for suggesting things 💃
done by fcb3973

bzz · 2018-05-09T06:40:47Z

docs/quickstart.md

+$ REPOS_PATH=~/gitbase/repos
+$ GITBASE_CONTAINER=gitbase
+$ BBLFSHD_CONTAINER=bblfsh
+$ GITBASE_IMAGE=dpordomingo/gitbase:latest


This is needed untill src-d/gitbase#262 resolved

I would put a comment right in the doc, if upstream issue does not get resolved quickly.

smola · 2018-05-09T09:13:48Z

.travis.yml

+
+stages:
+  - name: validate and build
+    if: >-


Is this condition meant to be... always run? You could just omit the if field here.

mmm... there are some cases where this stage won't run... but who cares... we can get rid of this tricky if, and run the tests always; I'll do so.

smola · 2018-05-09T09:16:15Z

.travis.yml

+  - docker
+
+go:
+  - "1.9.x"


... and tip with allow_failures, you're right @smola
I tried, but something was missing in the matrix... and some stages was not run when I tried it...
Could we open an issue with this requirements, merge as it is, and then proceed with it after merging?
If you agree, I'll open the issue to avoid forgeting it.

As agreed offline, we'll go with go 1.10.x and we'll iterate later with 1.9.x and tip.
I opened an issue #25 to ensure we address this requirement, and I'll change the 1.9.x with 1.10.x in this PR to be merged.

done by 10fd2d7

smola · 2018-05-09T09:20:10Z

.travis.yml

+    # push to dockerhub
+    - stage: push to dockerhub
+      script:
+        - make build


We should avoid building binaries for all OSes and arches here, building only the one that we use for Docker.

you're right @smola

What if I change it with:

script: - PKG_OS=linux make build - DOCKER_PUSH_LATEST=true make docker-push

(I realized that even removing the make build command, the Darwin binary will be also generated, so it seems to be needed the PKG_OS=linux env var, isn't it?)

We also need the make build command because there are "other things" that needs to be built for the docker image.

dpordomingo · 2018-05-09T11:11:24Z

This PR obtained a lot of feedback, many thanks folks!!!

Here are the last changes I did to address your comments:

60221c7 @smola sugestions about tricky condition in testing stage
4f15970 @smacker suggestions about docs in Makedile
553d837 @bzz suggestions about clarification in quickstart.md

Addressed with comment, so I'd need your approval or not:

@bzz about clarify DB connection string Add CI, docs and fix integration tests #15 (comment)
@smola about 1.10.x in Travis Add CI, docs and fix integration tests #15 (comment)

bzz · 2018-05-09T12:00:19Z

thank you @dpordomingo for such detailed followup 👏 Looks great to me.

Should be ready to merge after @smacker does another pass.

dpordomingo · 2018-05-09T13:33:19Z

All comments addressed; I'll squash and let you know once this is ready to be merged :D

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

- Avoid running integration tests as default ones - Rename integration tests as '*_integration_test.go' Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

dpordomingo · 2018-05-09T14:10:25Z

Travis succeeded with go 1.10.x
merging this; many thanks for your reviews 🙇‍♂️

dpordomingo added enhancement New feature or request new feature labels May 8, 2018

dpordomingo added this to the alpha0 milestone May 8, 2018

dpordomingo self-assigned this May 8, 2018

dpordomingo requested review from carlosms and bzz May 8, 2018 12:15

dpordomingo force-pushed the master branch 2 times, most recently from 0ad81d3 to 1c89a64 Compare May 8, 2018 12:24

dpordomingo mentioned this pull request May 8, 2018

Update build, for a single binary to include all fronted #5

Closed

3 tasks

carlosms mentioned this pull request May 8, 2018

Simple UI #16

Merged

carlosms reviewed May 8, 2018

View reviewed changes

dpordomingo force-pushed the master branch from 1c89a64 to 9aba382 Compare May 8, 2018 14:43

carlosms reviewed May 8, 2018

View reviewed changes

carlosms approved these changes May 8, 2018

View reviewed changes

smacker suggested changes May 8, 2018

View reviewed changes

bzz approved these changes May 9, 2018

View reviewed changes

smola reviewed May 9, 2018

View reviewed changes

dpordomingo mentioned this pull request May 9, 2018

Backend: Rethink how to work with assets, bindata... #24

Closed

smacker approved these changes May 9, 2018

View reviewed changes

dpordomingo mentioned this pull request May 9, 2018

CI: test go tip #25

Closed

dpordomingo force-pushed the master branch 3 times, most recently from 999f97d to 62975b5 Compare May 9, 2018 14:02

dpordomingo added 10 commits May 9, 2018 16:03

Add CodeOfConduct and DCO

627d967

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Add docs

1718510

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Add Dockerfile

fc8fbd4

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Add Makefile to build, test, run the app...

9868396

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Adi .travis.yml to enable CI

bf759c2

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Avoid running integration tests as default ones

e5bd1ad

- Avoid running integration tests as default ones - Rename integration tests as '*_integration_test.go' Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Run integration tests on demmand

7e459d2

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

Change default gitbase user

5295dd6

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

WORKAROUND 'src-d > dpordomingo' for "src-d/ci:vi"

c428eca

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

WORKAROUND 'src-d > dpordomingo' for gitbase DockerHub

2f13518

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>

dpordomingo force-pushed the master branch from 62975b5 to 2f13518 Compare May 9, 2018 14:05

dpordomingo merged commit fb177ae into src-d:master May 9, 2018

dpordomingo mentioned this pull request May 18, 2018

Enable integration tests in Travis src-d/ci#78

Closed


		Launch [bblfshd](https://github.com/bblfsh/bblfshd) and install the drivers. More info in the [bblfshd documentation](https://doc.bblf.sh/user/getting-started.html).
		Web application powered by [gitbase](https://github.com/src-d/gitbase), were you can query git repositories with a MySQL.


		Built binary:
		Read [more about how to run bblfsh and gitbase dependencies](docs/quickstart.md).


		It will test that `gitbase` and `bblfshd` are running and available for the playground.

		It is needed to serve under `gitbase` a copy of the `https://github.com/src-d/gitbase-playground` repository

		@@ -0,0 +1,70 @@
		# Quickstart

		## bblfsh and gitbase dependencies

		You have more information on the playground architecture and development guides in the [CONTRIBUTING.md#development](CONTRIBUTING.md#development).


		## run a query

		- serving the app for development purposes, [building and running it from sources](#run-from-sources)


		# Configuration


		Use `GITBASEPG_ENV=dev` for extra logs information.
		## Run the playground


		There are two main different ways to run the app:

		- using released artifacts, as [listed in the README.md#](../README.md#run-the-playground)

+                - docker
+              go:
+                - "1.9.x"

Add CI, docs and fix integration tests #15

Add CI, docs and fix integration tests #15

Conversation

dpordomingo commented May 8, 2018 • edited Loading

Assumptions for the first iteration

Documentation

CI in Travis:

Integration tests

dpordomingo commented May 8, 2018

bzz commented May 8, 2018 • edited Loading

dpordomingo commented May 8, 2018 • edited Loading

bzz commented May 8, 2018 • edited Loading

carlosms left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo May 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo May 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo May 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo commented May 8, 2018

dpordomingo commented May 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlosms left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smacker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smacker May 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo May 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo commented May 8, 2018

bzz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo commented May 8, 2018 •

edited

Loading

bzz commented May 8, 2018 •

edited

Loading

dpordomingo commented May 8, 2018 •

edited

Loading

bzz commented May 8, 2018 •

edited

Loading

dpordomingo May 8, 2018 •

edited

Loading

dpordomingo May 9, 2018 •

edited

Loading

dpordomingo May 8, 2018 •

edited

Loading

smacker May 9, 2018 •

edited

Loading

dpordomingo May 9, 2018 •

edited

Loading