Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse gluster connection for all tests #3

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

jfontan
Copy link
Contributor

@jfontan jfontan commented Jan 4, 2019

There were spurious connection problems in travis when it reconnected in each test. This also decreases the time spent testing.

Signed-off-by: Javi Fontan <jfontan@gmail.com>
@jfontan jfontan requested a review from a team January 4, 2019 14:30
Copy link

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose, it means that we'll need to clear up some stuff on gluster after every test?

@jfontan
Copy link
Contributor Author

jfontan commented Jan 4, 2019

@kuba-- it still cleans up temporary directories in each test but the connection to gluster is created once.

@jfontan jfontan merged commit 06fe134 into src-d:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants