This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: idxfile, avoid unnecessary building of reverse offset/hash map #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Navara <navara@emclient.com>
filipnavara
force-pushed
the
idxfile-reverse-index
branch
from
d21211b
to
74ae8aa
Compare
mcuadros
requested review from
erizocosmico and
jfontan
and removed request for
erizocosmico
erizocosmico
approved these changes
Apr 22, 2019
jfontan
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverse offset/hash map was always built because of the following code path:
ObjectStorage.getFromPackfileis called to lookup object by hashObjectStorage.decodeObjectAtcallsPackfile.GetByOffset(and alsoFindHash, to be addressed separately)Packfile.GetByOffsetcallsFindHashThus for every lookup in pack file the reverse offset/hash map was always built. Keeping it up to date with forward lookups avoids building the full map until an offset delta object is hit.