Add tests with strings and tables to engine_test.go for GREATEST/LEAST

Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
src-d · May 7, 2019 · a3fd865 · a3fd865
1 parent df87b11
commit a3fd865
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/engine_test.go b/engine_test.go
@@ -1064,10 +1064,42 @@ var queries = []struct {
 		`SELECT GREATEST(1, 2, 3, 4)`,
 		[]sql.Row{{int64(4)}},
 	},
+	{
+		`SELECT GREATEST(1, 2, "3", 4)`,
+		[]sql.Row{{float64(4)}},
+	},
+	{
+		`SELECT GREATEST(1, 2, "9", "foo999")`,
+		[]sql.Row{{float64(9)}},
+	},
+	{
+		`SELECT GREATEST("aaa", "bbb", "ccc")`,
+		[]sql.Row{{"ccc"}},
+	},
+	{
+		`SELECT GREATEST(i, s) FROM mytable`,
+		[]sql.Row{{float64(1)}, {float64(2)}, {float64(3)}},
+	},
 	{
 		`SELECT LEAST(1, 2, 3, 4)`,
 		[]sql.Row{{int64(1)}},
 	},
+	{
+		`SELECT LEAST(1, 2, "3", 4)`,
+		[]sql.Row{{float64(1)}},
+	},
+	{
+		`SELECT LEAST(1, 2, "9", "foo999")`,
+		[]sql.Row{{float64(1)}},
+	},
+	{
+		`SELECT LEAST("aaa", "bbb", "ccc")`,
+		[]sql.Row{{"aaa"}},
+	},
+	{
+		`SELECT LEAST(i, s) FROM mytable`,
+		[]sql.Row{{float64(1)}, {float64(2)}, {float64(3)}},
+	},
 }
 
 func TestQueries(t *testing.T) {

diff --git a/sql/expression/function/greatest_least.go b/sql/expression/function/greatest_least.go
@@ -80,7 +80,7 @@ func compEval(
 		return selectedString, nil
 	}
 
-	// float64
+	// sql.Float64
 	return float64(selectedNum), nil
 }