sleep function cannot be cancelled

[ajnavarro]

we are just calling to time.Sleep, and that cannot be canceled from the Context. Change sleep to make it cancellable.

[juanjux]

Easy way to reproduce: select sleep(1000) and control-C.

[creachadair]

This should do it:

// sleepContext sleeps for the specified duration or until ctx ends, and reports
// whether the sleep ended due to context cancellation.
func sleepContext(ctx context.Context, dur time.Duration) bool {
  select {
  case <-time.After(dur):
    return false
  case <-ctx.Done():
    return true
  }
}

Note that after the context ends the timer will run to completion before it will be GC'd. If that matters you can do something more explicit with time.NewTimer. But in general that is probably safe unless you start a lot of these and they run for a long time.

[juanjux]

Already fixed, forgot to close this :)

[juanjux]

Your solution is better since the fact that the After is of course interrupted if the ctx is Done went over me so I was dumbly doing smaller sleeps, I'm updating the PR, thanks!