This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Make Sleep check for cancelled context every second #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
Updated to use better solution by @creachadair, thanks! |
creachadair
reviewed
Aug 7, 2019
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix time scale Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Multiply duration for sleep inside the parents Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Multiply duration for sleep inside the parents Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
erizocosmico
suggested changes
Aug 8, 2019
sql/expression/function/sleep.go
Outdated
| time.Sleep(time.Duration(child.(float64)*1000) * time.Millisecond) | ||
| return 0, nil | ||
| select { | ||
| case <-time.After(time.Duration(child.(float64) * 1000) * time.Millisecond): |
There was a problem hiding this comment.
I would create a timer using time.NewTimer instead and then defer timer.Stop() so that we don't leave potentially long-running timers running unnecessarily.
ajnavarro
approved these changes
Aug 8, 2019
erizocosmico
suggested changes
Aug 8, 2019
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
erizocosmico
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech