This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
analyzer: execute rules in batches. #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
changed the title
erizocosmico
approved these changes
Jun 18, 2018
mcarmonaa
suggested changes
Jun 18, 2018
sql/analyzer/analyzer.go
Outdated
| } | ||
|
|
||
| const debugAnalyzerKey = "DEBUG_ANALYZER" | ||
| // AddPreValidationRule adds a new rule to the analyzer begore standard validation rules. |
|
apart of the typo, LGTM |
- Move all the iteration logic from `Analyzer` to `Batch`. Now `Analyzer` has a set of Batch objects instead of a set of Rules. - To be able to add custom rules, created an `AnalyzerBuilder` object. With it, you can build a custom `Analyzer` and add custom rules on specific Batches. This Batches can change depending on our necessities in the future. - Validation rules do not exist anymore. Now they are standard rules into a Batch that iterates only once. Signed-off-by: Antonio Jesus Navarro Perez <antnavper@gmail.com>
kuba--
approved these changes
Jun 18, 2018
mcarmonaa
approved these changes
Jun 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnalyzertoBatch. NowAnalyzerhas a set of Batch objects instead of a set of Rules.analyzer.Builderobject. With it, you can build a customAnalyzerand add custom rules on specific Batches. This Batches can change depending on our necessities in the future.Closes: #141
Signed-off-by: Antonio Jesus Navarro Perez antnavper@gmail.com