This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Fix filtered index #550
Merged
Fix filtered index #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfontan
reviewed
Nov 14, 2018
sql/index/pilosa/lookup.go
Outdated
| @@ -241,6 +244,9 @@ func (l *filteredLookup) values(p sql.Partition) (*pilosa.Row, error) { | |||
|
|
|||
| row = intersect(row, r) | |||
| } | |||
| if err := l.index.Close(); err != nil { | |||
There was a problem hiding this comment.
There are several cases where it can return an error and do not reach this line. Does it matter if l.index is not closed?
There was a problem hiding this comment.
Yes, we have to close it when something happen (and it's not because of pilosa, but more because we have reference counting in concurrentPilosaIndex).
But we have to close it asap (after first loop, so we cannot defer here)
There was a problem hiding this comment.
@jfontan - check it out
Signed-off-by: kuba-- <kuba@sourced.tech>
jfontan
approved these changes
Nov 14, 2018
ajnavarro
approved these changes
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
It fixes filtered and negate lookups (in the same way how it was done for regular lookup).
Thanks to this fix we may have intersect lookups with different conditions like:
a=1 AND b < 5