Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

allow all expressions in grouping, resolve orderby expressions #633

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

erizocosmico
Copy link
Contributor

Closes #630

This fixes 2 problems:

  • Not supporting arbitrary expressions in grouping
  • Not taking into account the children of the groupby expressions when reordering the projections underneath

@erizocosmico
Copy link
Contributor Author

Didn't notice tests were failing. Fixing

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

Tests should be fixed now.

@ajnavarro ajnavarro merged commit b829206 into src-d:master Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commits does not have column commit_author_when
3 participants