This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/expression: implement year UDF #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
force-pushed
the
feature/year-func
branch
from
792f55b
to
f6543f7
Compare
mcarmonaa
reviewed
Feb 28, 2018
sql/expression/function.go
Outdated
|
|
||
| // TransformUp implements the Expression interface. | ||
| func (y *Year) TransformUp(f func(sql.Expression) sql.Expression) sql.Expression { | ||
| return f(NewYear(f(y.Child))) |
There was a problem hiding this comment.
Why is not needed call TransformUp on y.Child too?
There was a problem hiding this comment.
It is, good catch!
erizocosmico
force-pushed
the
feature/year-func
branch
from
f6543f7
to
5f7a22b
Compare
mcarmonaa
approved these changes
Feb 28, 2018
erizocosmico
force-pushed
the
feature/year-func
branch
2 times, most recently
from
2924cda
to
7a04fc1
Compare
ajnavarro
approved these changes
Feb 28, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/year-func
branch
from
7a04fc1
to
50328eb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43