This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Add build, tag for oniguruma, remove for mysql_go_regex, update README #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
approved these changes
Apr 5, 2019
kuba--
reviewed
Apr 5, 2019
go.sum
Outdated
| @@ -69,6 +69,8 @@ github.com/opentracing/opentracing-go v1.0.2 h1:3jA2P6O1F9UOrWVpwrIo17pu01KWvNWg | |||
| github.com/opentracing/opentracing-go v1.0.2/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o= | |||
| github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c h1:Lgl0gzECD8GnQ5QCWA8o6BtfL6mDH5rQgM4/fX3avOs= | |||
| github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc= | |||
| github.com/pbnjay/memory v0.0.0-20190104145345-974d429e7ae4 h1:MfIUBZ1bz7TgvQLVa/yPJZOGeKEgs6eTKUjz3zB4B+U= | |||
There was a problem hiding this comment.
Seems go mod tidy added it.
There was a problem hiding this comment.
go mod why github.com/pbnjay/memory
go: finding github.com/uber/jaeger-lib/metrics/testutils latest
go: finding github.com/uber/jaeger-lib/metrics latest
# github.com/pbnjay/memory
gopkg.in/src-d/go-mysql-server.v0/sql/plan
github.com/pbnjay/memory
internal/regex/regex_oniguruma.go
Outdated
| @@ -1,3 +1,5 @@ | |||
| // +build mysql_go_onigurama | |||
There was a problem hiding this comment.
enry has just oniguruma afaik
There was a problem hiding this comment.
It was for symmetry with the previous tag, but will change it to onigurama.
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
force-pushed
the
onigurama-tag
branch
2 times, most recently
from
a031102
to
c4dd3e4
Compare
|
@juanjux it is |
Rename onigurama tag to just onigurama Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix typo Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
changed the title
|
@ajnavarro renamed... |
kuba--
approved these changes
Apr 5, 2019
erizocosmico
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech