This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Pass function name to the registry #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
changed the title
juanjux
approved these changes
Apr 10, 2019
erizocosmico
suggested changes
Apr 10, 2019
ajnavarro
approved these changes
Apr 10, 2019
ajnavarro
reviewed
Apr 10, 2019
|
@ajnavarro the map provides an useful feature: ensuring function names are unique. If we transform it into a slice, we will lose that. |
|
@erizocosmico we could handle that in RegisterFunctions, right? (throwing an error or panicking) But it's just a suggestion to avoid in the future having some inconsistencies between the name used to register and the function name (now only used on errors). If it's worth it to keep the map, LGTM. |
|
Oh, you're right, we could panic on RegisterFunction |
|
How about this? |
Signed-off-by: kuba-- <kuba@sourced.tech>
ajnavarro
approved these changes
Apr 11, 2019
|
@erizocosmico PTAL |
erizocosmico
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
Partly fixes: #665
This PR passes a function name to the registry, so it can improve debugging and error messages.