This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Fix jaeger-lib dependency #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeger-client-go is not compatible with jaeger-lib 2.0.0 that was set in go.mod. Now uses 1.5.0 that is compatible and is the one in pilosa go.mod. With this change gitbase is able to use go-mysql-server with go.mod. This problem is mentioned here: jaegertracing/jaeger-client-go#363 (comment) Signed-off-by: Javi Fontan <jfontan@gmail.com>
ajnavarro
approved these changes
Apr 18, 2019
kuba--
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jaeger-client-gois not compatible withjaeger-lib2.0.0 that was set ingo.mod. Now uses 1.5.0 that is compatible and is the one in pilosago.mod.With this change gitbase is able to use
go-mysql-serverwithgo.mod.This problem is mentioned here:
jaegertracing/jaeger-client-go#363 (comment)