Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

sql/analyzer: run convert_dates rule after prune_columns #703

Merged
merged 1 commit into from
May 8, 2019

Conversation

erizocosmico
Copy link
Contributor

After a while debugging on gitbase I realised only this fix would also fix all the problems it had with squash rule with much less code.

Analyzer bugs are weird 🤷‍♂

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico requested a review from a team May 7, 2019 09:19
@erizocosmico erizocosmico self-assigned this May 7, 2019
@juanjux
Copy link
Contributor

juanjux commented May 7, 2019

I wonder the debug process you followed to discover that, anyway you're a coding monster.

@erizocosmico
Copy link
Contributor Author

@juanjux went down the rabbit hole adding more logic to the squash rule until I saw prune_columns was not working as expected because of things convert_dates was doing. Executing it later made all problems go away. Actually, the only requirement convert_dates has is to execute before pushdown and after everything has been resolved. So I moved it just before pushdown.

@erizocosmico
Copy link
Contributor Author

Shall we merge this @ajnavarro?

@erizocosmico erizocosmico added the bug Something isn't working label May 7, 2019
@erizocosmico erizocosmico merged commit dbd7fe9 into src-d:master May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants