This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/analyzer: do not use plan.Inspect to find available tables #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
force-pushed
the
fix/inspect-available-tables
branch
from
5b5e98c
to
397fab3
Compare
kuba--
reviewed
May 13, 2019
| return tables | ||
| } | ||
|
|
||
| func getNodesAvailableTables(tables map[string]string, nodes ...sql.Node) { |
There was a problem hiding this comment.
maybe it can also return a tables map - WDYT?
There was a problem hiding this comment.
The reason why this does not return a table map is because it takes one as a parameter to add stuff to it and avoid having to merge maps since this is called recursively. It could return a map but it's pointless because it will return the same map as the one it receives.
There was a problem hiding this comment.
Makes sense. It's still tail recursion, so OK.
kuba--
approved these changes
May 13, 2019
ajnavarro
approved these changes
May 13, 2019
kuba--
reviewed
May 13, 2019
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
fix/inspect-available-tables
branch
from
397fab3
to
49739a0
Compare
|
Shall we merge this, @ajnavarro? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friday night this possible bug came to my mind, but PR was merged because I got a chance to fix it tomorrow 😅
Because of how plan.Inspect works, whenever a table is found in a branch the other branches are not inspected anymore. Instead, doing recursive calls all branches are visited.