Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Add metrics (engine, analyzer, regex, pilosa) based on go-kit interface. #744

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Conversation

kuba--
Copy link
Contributor

@kuba-- kuba-- commented Jun 4, 2019

Signed-off-by: kuba-- kuba@sourced.tech
Orchestrate mysql server by metrics based on go-kit metrics interface.

Generic implementation (to satisfy prometheus, etc.) comes with some constraints (like you cannot reregister the same metric, you cannot reuse constructors, so we cannot pass builders to some kind of registry etc.). So, we ended up with following proposal, where you have to initialize global vars per package.

By default all metrics are based on discard implementation which is basically noop.

@kuba-- kuba-- requested a review from a team June 4, 2019 17:30
@kuba-- kuba-- added the proposal proposal for new additions or changes label Jun 4, 2019
engine.go Show resolved Hide resolved
_example/main.go Outdated Show resolved Hide resolved
@ajnavarro
Copy link
Contributor

@kuba-- could you rebase please?

@ajnavarro ajnavarro merged commit 5c36654 into src-d:master Jun 12, 2019
@kuba-- kuba-- deleted the metrics branch June 12, 2019 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal proposal for new additions or changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants